security analytics dashboard plugin cypress tests update

[jovancacvetkovic]

Description

Syncs new rule tests of the security analytics dashboard plugin with functional tests

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[AWSHurneyt]

I don't seem to have permissions to apply labels, or run the checks for PRs in this repo. Would someone mind adding the backport 2.x label to this PR? This is targeting the 2.8 release.

[AWSHurneyt]

@CCongWang @kavilla
It looks like the Security Analytics Release tests, Reports Release tests, and Backport workflows failed with only a This job failed error appearing on the details page. Would you happen to have an idea of what could cause that?

I also noticed that the CodeQL workflow failed with This version of the CodeQL Action was deprecated on January 18th, 2023, and is no longer updated or supported, but I don't think that would necessarily block the PR.

[CCongWang]

there is a customized command with the same name createDetector in https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/cypress/utils/plugins/security-analytics-dashboards-plugin/detectors.js#L9, not sure if it's confusing to use the same name but have different function

[CCongWang]

Also this file has both customized commands and a util function, and this file is imported in commands.js, should we just have commands in this file?

[jovancacvetkovic]

@CCongWang The util function is removed. I'll refactor it in some next PR.

[CCongWang]

I don't have much context on this file, but looks like most of the customized commands are not added in this file? I see there are three ways to add customized commands:

• just add a command in cypress/utils/plugins/{plugin}/commands.js
• add a command in cypress/utils/plugins/{plugin}/commands.js and then declare the command in cypress/utils/plugins/{plugin}/index.d.ts, example: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/cypress/utils/plugins/security-dashboards-plugin/index.d.ts
• add a command in cypress/utils/plugins/{plugin}/commands.js and then declare the command in cypress/utils/index.d.ts

Do we have a preference? @kavilla @ashwin-pc @ohltyler

[jovancacvetkovic]

@CCongWang I have refactored commands, all are now in the commands file and declared in index.d.ts within the plugins folder.

[CCongWang]

Hi @AWSHurneyt , for failed CodeQL workflow, looks like the deprecation message is just a warning, see this successful example: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/4636082170/jobs/8249870977?pr=608
the true error is:

Uploading results
  Processing sarif files: ["/home/runner/work/opensearch-dashboards-functional-test/results/javascript.sarif"]
  Uploading results
  Error: Server Error

I'm gonna rerun to see if it's something transient

[CCongWang]

@AWSHurneyt for the other failed workflows with This job failed, I guess it was due to some flakyness, rerunning

[jovancacvetkovic]

Would someone re-run the tests? I don't have permission to run the tests.

[jovancacvetkovic]

Security analytics team is working on a problem with the plugin build, the fix is in the PR but will have to wait for it to be merged before the tests for the security analytics can be run successfully.