-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing form field in gantt-chart, observability and workbench #424
Conversation
Signed-off-by: Shenoy Pratik <[email protected]>
Cypress Test run results for the modified tests: without-security
with-security
|
ui.spec.js.mp40_before.spec.js.mp4gantt_ui.spec.js.mp4 |
Signed-off-by: Shenoy Pratik <[email protected]>
@tianleh do you know why the three plugins pass locally but fail in workflow?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. seems still failing in github actions?
@ps48 Could you share more details about your local setup? e.g operating system, browser and test command. From the output you attached, it looks like you are using browser Also could you rerun the workflow a few more times to see if this is an transient issue or a deterministic issue? |
The workflow test artifacts can be checked here https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3697326419 You can follow these steps to get it: open workflow from the PR page, then click the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the workflow failure
@tianleh, as dicussed offline. I'm still waiting for a stable dashboards distribution build in version 3.0.0 which has gantt-charts and Observability plugin built-in. |
This PR is blocked by failed workflow because we don't have a stable dashboards distribution build in version 3.0.0. I think we can merge the PR for now, since @ps48 has uploaded all local test results. |
Looks good to me. |
* removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df)
* removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df)
#457) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]>
#459) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]>
#462) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]>
#460) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]>
#461) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]>
#463) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]>
#458) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]>
* removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df)
#477) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]>
#461) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]> Signed-off-by: Cong Wang <[email protected]>
…search-project#424) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Jakub Przybylski <[email protected]>
…search-project#424) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df)
…search-project#424) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Signed-off-by: Joshua Li <[email protected]>
…search-project#424) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Signed-off-by: Joshua Li <[email protected]>
…search-project#424) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Signed-off-by: Joshua Li <[email protected]>
#810) * removing form field in gantt-chart, observability and workbench (cherry picked from commit bac02df) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
#809) * removing form field in gantt-chart, observability and workbench (cherry picked from commit bac02df) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
#811) * removing form field in gantt-chart, observability and workbench (cherry picked from commit bac02df) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Shenoy Pratik <[email protected]>
…search-project#424) (opensearch-project#458) * removing form field in gantt-chart, observability and workbench Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit bac02df) Co-authored-by: Shenoy Pratik <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Shenoy Pratik [email protected]
Description
The functional tests for gantt-chart, observability and workbench were over-riding the default cypress form field in api requests to OpenSearch. This was leading to error as form field override is only necessary when this header is set to
x-www-form-urlencoded
Solution: Removed the form field as it is not required in the tests.
Issues Resolved
#313
#310
#311
#312
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.