Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing form field in gantt-chart, observability and workbench #424

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Dec 13, 2022

Signed-off-by: Shenoy Pratik [email protected]

Description

The functional tests for gantt-chart, observability and workbench were over-riding the default cypress form field in api requests to OpenSearch. This was leading to error as form field override is only necessary when this header is set to x-www-form-urlencoded

Solution: Removed the form field as it is not required in the tests.

Issues Resolved

#313
#310
#311
#312

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 requested a review from a team as a code owner December 13, 2022 21:45
@ps48
Copy link
Member Author

ps48 commented Dec 13, 2022

Cypress Test run results for the modified tests:

without-security

=====================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        9.5.4                                                                          │
  │ Browser:        Electron 94 (headless)                                                         │
  │ Node Version:   v14.20.0 (/Users/sgguruda/.nvm/versions/node/v14.20.0/bin/node)                │
  │ Specs:          1 found (plugins/gantt-chart-dashboards/gantt_ui.spec.js)                      │
  │ Searched:       cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js            │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  plugins/gantt-chart-dashboards/gantt_ui.spec.js                                 (1 of 1)


  Dump test data
    ✓ Indexes test data for gantt chart

  Save a gantt chart
    ✓ Creates and saves a gantt chart (9620ms)

  Render and configure a gantt chart
    ✓ Renders no data message
    ✓ Renders the chart (5910ms)

  Configure panel settings
    ✓ Changes y-axis label
    ✓ Changes x-axis label (5870ms)
    ✓ Changes time formats (7563ms)
    ✓ Hides legends

  Add gantt chart to dashboard
    ✓ Adds gantt chart to dashboard


  9 passing (47s)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        9                                                                                │
  │ Passing:      9                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     47 seconds                                                                       │
  │ Spec Ran:     plugins/gantt-chart-dashboards/gantt_ui.spec.js                                  │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /Users/sgguruda/work/git_codebase/opensearch-dashboards-fun    (4 seconds)
                          ctional-test/cypress/videos/plugins/gantt-chart-dashboards/               
                          gantt_ui.spec.js.mp4                                                      


=====================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/gantt-chart-dashboards/gant      00:47        9        9        -        -        - │
  │    t_ui.spec.js                                                                                │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:47        9        9        -        -        -  


=====================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        9.5.4                                                                          │
  │ Browser:        Electron 94 (headless)                                                         │
  │ Node Version:   v14.20.0 (/Users/sgguruda/.nvm/versions/node/v14.20.0/bin/node)                │
  │ Specs:          1 found (plugins/observability-dashboards/0_before.spec.js)                    │
  │ Searched:       cypress/integration/plugins/observability-dashboards/0_before.spec.js          │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  plugins/observability-dashboards/0_before.spec.js                               (1 of 1)


  Before
    ✓ setup completed (13442ms)


  1 passing (14s)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        1                                                                                │
  │ Passing:      1                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     13 seconds                                                                       │
  │ Spec Ran:     plugins/observability-dashboards/0_before.spec.js                                │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /Users/sgguruda/work/git_codebase/opensearch-dashboards-fun     (1 second)
                          ctional-test/cypress/videos/plugins/observability-dashboard               
                          s/0_before.spec.js.mp4                                                    


=====================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/observability-dashboards/0_      00:13        1        1        -        -        - │
  │    before.spec.js                                                                              │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:13        1        1        -        -        -  


=====================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        9.5.4                                                                          │
  │ Browser:        Electron 94 (headless)                                                         │
  │ Node Version:   v14.20.0 (/Users/sgguruda/.nvm/versions/node/v14.20.0/bin/node)                │
  │ Specs:          1 found (plugins/query-workbench-dashboards/ui.spec.js)                        │
  │ Searched:       cypress/integration/plugins/query-workbench-dashboards/ui.spec.js              │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  plugins/query-workbench-dashboards/ui.spec.js                                   (1 of 1)


  Dump test data
    ✓ Indexes test data for SQL and PPL

  Test PPL UI
    ✓ Confirm results are empty (6941ms)
    ✓ Test Run button (5672ms)
    ✓ Test Clear button (7978ms)
    ✓ Test full screen view (6410ms)

  Test SQL UI
    ✓ Confirm results are empty
    ✓ Test Run button and field search (5943ms)
    ✓ Test Translate button (6212ms)
    ✓ Test Clear button
    ✓ Test full screen view

  Test and verify SQL downloads
    ✓ Download and verify JSON
    ✓ Download and verify JDBC
    ✓ Download and verify CSV
    ✓ Download and verify Text

  Test table display
    ✓ Test GROUP BY (6818ms)
    ✓ Test GROUP BY with aliases and scalar function (6444ms)
    ✓ Test GROUP BY and HAVING (6953ms)
    ✓ Test ORDER BY (7609ms)
    ✓ Test JOIN (7999ms)
    ✓ Test nested fields display (8187ms)


  20 passing (2m)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        20                                                                               │
  │ Passing:      20                                                                               │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     1 minute, 34 seconds                                                             │
  │ Spec Ran:     plugins/query-workbench-dashboards/ui.spec.js                                    │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /Users/sgguruda/work/git_codebase/opensearch-dashboards-fun    (7 seconds)
                          ctional-test/cypress/videos/plugins/query-workbench-dashboa               
                          rds/ui.spec.js.mp4                                                        


=====================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/query-workbench-dashboards/      01:34       20       20        -        -        - │
  │    ui.spec.js                                                                                  │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        01:34       20       20        -        -        -  

with-security


=====================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        9.5.4                                                                          │
  │ Browser:        Electron 94 (headless)                                                         │
  │ Node Version:   v14.20.0 (/Users/sgguruda/.nvm/versions/node/v14.20.0/bin/node)                │
  │ Specs:          1 found (plugins/gantt-chart-dashboards/gantt_ui.spec.js)                      │
  │ Searched:       cypress/integration/plugins/gantt-chart-dashboards/gantt_ui.spec.js            │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  plugins/gantt-chart-dashboards/gantt_ui.spec.js                                 (1 of 1)


  Dump test data
    ✓ Indexes test data for gantt chart

  Save a gantt chart
    ✓ Creates and saves a gantt chart (13260ms)

  Render and configure a gantt chart
    ✓ Renders no data message
    ✓ Renders the chart (5538ms)

  Configure panel settings
    ✓ Changes y-axis label
    ✓ Changes x-axis label (5627ms)
    ✓ Changes time formats (7096ms)
    ✓ Hides legends

  Add gantt chart to dashboard
    ✓ Adds gantt chart to dashboard


  9 passing (49s)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        9                                                                                │
  │ Passing:      9                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     49 seconds                                                                       │
  │ Spec Ran:     plugins/gantt-chart-dashboards/gantt_ui.spec.js                                  │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /Users/sgguruda/work/git_codebase/opensearch-dashboards-fun    (4 seconds)
                          ctional-test/cypress/videos/plugins/gantt-chart-dashboards/               
                          gantt_ui.spec.js.mp4                                                      


=====================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/gantt-chart-dashboards/gant      00:49        9        9        -        -        - │
  │    t_ui.spec.js                                                                                │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:49        9        9        -        -        -  


=====================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        9.5.4                                                                          │
  │ Browser:        Electron 94 (headless)                                                         │
  │ Node Version:   v14.20.0 (/Users/sgguruda/.nvm/versions/node/v14.20.0/bin/node)                │
  │ Specs:          1 found (plugins/observability-dashboards/0_before.spec.js)                    │
  │ Searched:       cypress/integration/plugins/observability-dashboards/0_before.spec.js          │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  plugins/observability-dashboards/0_before.spec.js                               (1 of 1)


  Before
    ✓ setup completed (15027ms)


  1 passing (15s)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        1                                                                                │
  │ Passing:      1                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     15 seconds                                                                       │
  │ Spec Ran:     plugins/observability-dashboards/0_before.spec.js                                │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /Users/sgguruda/work/git_codebase/opensearch-dashboards-fun     (1 second)
                          ctional-test/cypress/videos/plugins/observability-dashboard               
                          s/0_before.spec.js.mp4                                                    


=====================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/observability-dashboards/0_      00:15        1        1        -        -        - │
  │    before.spec.js                                                                              │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:15        1        1        -        -        -  


=====================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        9.5.4                                                                          │
  │ Browser:        Electron 94 (headless)                                                         │
  │ Node Version:   v14.20.0 (/Users/sgguruda/.nvm/versions/node/v14.20.0/bin/node)                │
  │ Specs:          1 found (plugins/query-workbench-dashboards/ui.spec.js)                        │
  │ Searched:       cypress/integration/plugins/query-workbench-dashboards/ui.spec.js              │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  plugins/query-workbench-dashboards/ui.spec.js                                   (1 of 1)


  Dump test data
    ✓ Indexes test data for SQL and PPL

  Test PPL UI
    ✓ Confirm results are empty (6792ms)
    ✓ Test Run button (5565ms)
    ✓ Test Clear button (7847ms)
    ✓ Test full screen view (6542ms)

  Test SQL UI
    ✓ Confirm results are empty
    ✓ Test Run button and field search (6595ms)
    ✓ Test Translate button (6604ms)
    ✓ Test Clear button
    ✓ Test full screen view

  Test and verify SQL downloads
    ✓ Download and verify JSON
    ✓ Download and verify JDBC
    ✓ Download and verify CSV
    ✓ Download and verify Text

  Test table display
    ✓ Test GROUP BY (6127ms)
    ✓ Test GROUP BY with aliases and scalar function (6253ms)
    ✓ Test GROUP BY and HAVING (7022ms)
    ✓ Test ORDER BY (7305ms)
    ✓ Test JOIN (8972ms)
    ✓ Test nested fields display (8588ms)


  20 passing (2m)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        20                                                                               │
  │ Passing:      20                                                                               │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     1 minute, 35 seconds                                                             │
  │ Spec Ran:     plugins/query-workbench-dashboards/ui.spec.js                                    │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /Users/sgguruda/work/git_codebase/opensearch-dashboards-fun    (7 seconds)
                          ctional-test/cypress/videos/plugins/query-workbench-dashboa               
                          rds/ui.spec.js.mp4                                                        


=====================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/query-workbench-dashboards/      01:35       20       20        -        -        - │
  │    ui.spec.js                                                                                  │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        01:35       20       20        -        -        -  

@ps48
Copy link
Member Author

ps48 commented Dec 13, 2022

ui.spec.js.mp4
0_before.spec.js.mp4
gantt_ui.spec.js.mp4

Signed-off-by: Shenoy Pratik <[email protected]>
@CCongWang
Copy link
Collaborator

@tianleh do you know why the three plugins pass locally but fail in workflow??

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. seems still failing in github actions?

@tianleh
Copy link
Member

tianleh commented Dec 16, 2022

@tianleh do you know why the three plugins pass locally but fail in workflow??

@ps48 Could you share more details about your local setup? e.g operating system, browser and test command. From the output you attached, it looks like you are using browser Electron 94 (headless) instead of Chromium 108 (headless) used in the Github workflow.

Also could you rerun the workflow a few more times to see if this is an transient issue or a deterministic issue?

@tianleh
Copy link
Member

tianleh commented Dec 16, 2022

The workflow test artifacts can be checked here https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3697326419

You can follow these steps to get it: open workflow from the PR page, then click the Summary button. @ps48

Copy link
Member

@tianleh tianleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the workflow failure

@ps48
Copy link
Member Author

ps48 commented Dec 20, 2022

Please check the workflow failure

@tianleh, as dicussed offline. I'm still waiting for a stable dashboards distribution build in version 3.0.0 which has gantt-charts and Observability plugin built-in.

@CCongWang
Copy link
Collaborator

This PR is blocked by failed workflow because we don't have a stable dashboards distribution build in version 3.0.0. I think we can merge the PR for now, since @ps48 has uploaded all local test results.
This PR should be backported to 1.3 - 2.4 for now, and once the current 2.5 release tests are complete, I will backport it to 2.5.
Any comments/concerns/questions?
cc: @tianleh @joshuali925

@tianleh
Copy link
Member

tianleh commented Jan 20, 2023

This PR is blocked by failed workflow because we don't have a stable dashboards distribution build in version 3.0.0. I think we can merge the PR for now, since @ps48 has uploaded all local test results.
This PR should be backported to 1.3 - 2.4 for now, and once the current 2.5 release tests are complete, I will backport it to 2.5.
Any comments/concerns/questions?
cc: @tianleh @joshuali925

Looks good to me.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2023
* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2023
* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)
CCongWang pushed a commit that referenced this pull request Jan 25, 2023
#457)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
CCongWang pushed a commit that referenced this pull request Jan 25, 2023
#459)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
CCongWang pushed a commit that referenced this pull request Jan 25, 2023
#462)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
CCongWang pushed a commit that referenced this pull request Jan 25, 2023
#460)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
CCongWang pushed a commit that referenced this pull request Jan 25, 2023
#461)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
CCongWang pushed a commit that referenced this pull request Jan 25, 2023
#463)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
CCongWang pushed a commit that referenced this pull request Jan 25, 2023
#458)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
@ananzh ananzh mentioned this pull request Jan 30, 2023
16 tasks
@tianleh tianleh added the v1.3.8 label Jan 31, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2023
* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)
ps48 added a commit that referenced this pull request Feb 9, 2023
#477)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
CCongWang pushed a commit that referenced this pull request Feb 10, 2023
#461)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
Signed-off-by: Cong Wang <[email protected]>
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
…search-project#424)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Jakub Przybylski <[email protected]>
joshuali925 pushed a commit to joshuali925/opensearch-dashboards-functional-test that referenced this pull request Aug 31, 2023
…search-project#424)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)
joshuali925 pushed a commit to joshuali925/opensearch-dashboards-functional-test that referenced this pull request Aug 31, 2023
…search-project#424)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)
Signed-off-by: Joshua Li <[email protected]>
joshuali925 pushed a commit to joshuali925/opensearch-dashboards-functional-test that referenced this pull request Aug 31, 2023
…search-project#424)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)
Signed-off-by: Joshua Li <[email protected]>
joshuali925 pushed a commit to joshuali925/opensearch-dashboards-functional-test that referenced this pull request Aug 31, 2023
…search-project#424)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)
Signed-off-by: Joshua Li <[email protected]>
peterzhuamazon pushed a commit that referenced this pull request Sep 5, 2023
#810)

* removing form field in gantt-chart, observability and workbench


(cherry picked from commit bac02df)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>
peterzhuamazon pushed a commit that referenced this pull request Sep 5, 2023
#809)

* removing form field in gantt-chart, observability and workbench


(cherry picked from commit bac02df)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>
peterzhuamazon pushed a commit that referenced this pull request Sep 5, 2023
#811)

* removing form field in gantt-chart, observability and workbench


(cherry picked from commit bac02df)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>
leanneeliatra pushed a commit to leanneeliatra/opensearch-dashboards-functional-test-fork that referenced this pull request Sep 15, 2023
…search-project#424) (opensearch-project#458)

* removing form field in gantt-chart, observability and workbench

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit bac02df)

Co-authored-by: Shenoy Pratik <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants