Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update observability tests #399

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Update observability tests #399

merged 4 commits into from
Jan 11, 2023

Conversation

mengweieric
Copy link
Contributor

@mengweieric mengweieric commented Nov 16, 2022 •
edited
Loading

Description

Removed/updated observability tests.

Issues Resolved

#289

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mengweieric mengweieric requested a review from a team as a code owner November 16, 2022 23:47
ashwin-pc
ashwin-pc reviewed Nov 17, 2022
View reviewed changes
cypress/integration/plugins/observability-dashboards/7_app_analytics.spec.js Outdated
@@ -453,6 +254,7 @@ describe('Application Analytics home page', () => {
.within(() => {
cy.get('.euiCheckbox').click();
});
cy.wait(delayTime);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a better way to implement this? wait(ms) should be almost universally avoided. The sony exception i can think of is when debouncing is involved.

@ashwin-pc
Copy link
Member

@mengweieric looks like your tests dont pass the CI. Also can you attach the video for the updated tests?

@mengweieric
Copy link
Contributor Author

@mengweieric looks like your tests dont pass the CI. Also can you attach the video for the updated tests?

Sure later will update PR to address the issue and upload video.

@mengweieric mengweieric mentioned this pull request Dec 9, 2022
Closed
40 tasks
@mengweieric
Copy link
Contributor Author

Test videos

1_trace_analytics_dashboard.spec.js.mp4
2_trace_analytics_services.spec.js.mp4
3_trace_analytics_traces.spec.js.mp4
4_panels.spec.js.mp4
5_event_analytics.spec.js.mp4
6_notebooks.spec.js.mp4
7_app_analytics.spec.js.mp4

@mengweieric
Copy link
Contributor Author

Screen Shot 2023-01-11 at 1 20 09 PM

@mengweieric mengweieric requested a review from ashwin-pc January 11, 2023 21:28
@tianleh tianleh requested a review from joshuali925 January 11, 2023 21:59
@mengweieric mengweieric merged commit 3990e29 into opensearch-project:main Jan 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
@mengweieric @github-actions
Update observability tests (#399)
d2508f2 
* removed and updated event analytics tests

Signed-off-by: Eric Wei <[email protected]>

* removed some panel tests

Signed-off-by: Eric Wei <[email protected]>

* removed and updated app analytics tests

Signed-off-by: Eric Wei <[email protected]>

* updated observability tests

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 3990e29)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 11, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
@mengweieric @github-actions
Update observability tests (#399)
d16f344 
* removed and updated event analytics tests

Signed-off-by: Eric Wei <[email protected]>

* removed some panel tests

Signed-off-by: Eric Wei <[email protected]>

* removed and updated app analytics tests

Signed-off-by: Eric Wei <[email protected]>

* updated observability tests

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 3990e29)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 11, 2023
Merged
mengweieric added a commit that referenced this pull request Jan 11, 2023
@opensearch-trigger-bot @mengweieric
Update observability tests (#399) (#448)
1f83b67 
* removed and updated event analytics tests

Signed-off-by: Eric Wei <[email protected]>

* removed some panel tests

Signed-off-by: Eric Wei <[email protected]>

* removed and updated app analytics tests

Signed-off-by: Eric Wei <[email protected]>

* updated observability tests

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 3990e29)

Co-authored-by: Eric Wei <[email protected]>
@mengweieric mengweieric deleted the update-obs-tests branch January 11, 2023 22:18
mengweieric added a commit that referenced this pull request Feb 10, 2023
@opensearch-trigger-bot @mengweieric
Update observability tests (#399) (#447)
5ce70b4 
* removed and updated event analytics tests

Signed-off-by: Eric Wei <[email protected]>

* removed some panel tests

Signed-off-by: Eric Wei <[email protected]>

* removed and updated app analytics tests

Signed-off-by: Eric Wei <[email protected]>

* updated observability tests

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 3990e29)

Co-authored-by: Eric Wei <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 10, 2023
@mengweieric @github-actions
Update observability tests (#399)
c89e097 
* removed and updated event analytics tests

Signed-off-by: Eric Wei <[email protected]>

* removed some panel tests

Signed-off-by: Eric Wei <[email protected]>

* removed and updated app analytics tests

Signed-off-by: Eric Wei <[email protected]>

* updated observability tests

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 3990e29)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 10, 2023
Merged
CCongWang pushed a commit that referenced this pull request Feb 10, 2023
@opensearch-trigger-bot @mengweieric
Update observability tests (#399) (#511)
5138fb1 
* removed and updated event analytics tests

Signed-off-by: Eric Wei <[email protected]>

* removed some panel tests

Signed-off-by: Eric Wei <[email protected]>

* removed and updated app analytics tests

Signed-off-by: Eric Wei <[email protected]>

* updated observability tests

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 3990e29)

Co-authored-by: Eric Wei <[email protected]>
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
@mengweieric @jakubp-eliatra
Update observability tests (opensearch-project#399)
67e8f81 
* removed and updated event analytics tests

Signed-off-by: Eric Wei <[email protected]>

* removed some panel tests

Signed-off-by: Eric Wei <[email protected]>

* removed and updated app analytics tests

Signed-off-by: Eric Wei <[email protected]>

* updated observability tests

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: Jakub Przybylski <[email protected]>
leanneeliatra pushed a commit to leanneeliatra/opensearch-dashboards-functional-test-fork that referenced this pull request Sep 15, 2023
@opensearch-trigger-bot @mengweieric @leanneeliatra
Update observability tests (opensearch-project#399) (opensearch-proje…
01b4dcd 
…ct#447)

* removed and updated event analytics tests

Signed-off-by: Eric Wei <[email protected]>

* removed some panel tests

Signed-off-by: Eric Wei <[email protected]>

* removed and updated app analytics tests

Signed-off-by: Eric Wei <[email protected]>

* updated observability tests

Signed-off-by: Eric Wei <[email protected]>

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 3990e29)

Co-authored-by: Eric Wei <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianleh tianleh tianleh approved these changes

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925

Assignees
No one assigned
Labels
backport 2.x backport 2.4 backport 2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengweieric @ashwin-pc @tianleh @peterzhuamazon