-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] update test for common delete modal #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origin: opensearch-project/observability@9d16389 Signed-off-by: Kawika Avilla <[email protected]>
eugenesk24
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rocky!!
CCongWang
approved these changes
Jul 25, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
Origin: opensearch-project/observability@9d16389 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit f6fc9a0)
tianleh
reviewed
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kavilla
added a commit
that referenced
this pull request
Jul 25, 2022
Origin: opensearch-project/observability@9d16389 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit f6fc9a0) Co-authored-by: Kawika Avilla <[email protected]>
CCongWang
pushed a commit
that referenced
this pull request
Feb 10, 2023
Origin: opensearch-project/observability@9d16389 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit f6fc9a0) Co-authored-by: Kawika Avilla <[email protected]> Signed-off-by: Cong Wang <[email protected]>
jakubp-eliatra
pushed a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 24, 2023
…ct#268) Origin: opensearch-project/observability@9d16389 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Jakub Przybylski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Origin: opensearch-project/observability@9d16389
Signed-off-by: Kawika Avilla [email protected]
Issues Related
opensearch-project/opensearch-build#1818
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.