-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace]Add cypress for breadcrumbs #1642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
force-pushed
the
workspace_ft
branch
from
November 14, 2024 15:03
b9b4203
to
29f7058
Compare
Hailong-am
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
November 15, 2024 01:26
Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe
approved these changes
Nov 15, 2024
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
changed the title
[]Add cypress for breadcrumbs
[workspace]Add cypress for breadcrumbs
Nov 15, 2024
Hailong-am
force-pushed
the
workspace_ft
branch
2 times, most recently
from
November 15, 2024 06:08
dd891f1
to
7250334
Compare
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
force-pushed
the
workspace_ft
branch
from
November 15, 2024 06:45
7250334
to
f8e197e
Compare
raintygao
approved these changes
Nov 18, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1642-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd7a18f65f5467a079218e73b02d836fa6d8cbdc
# Push it to GitHub
git push --set-upstream origin backport/backport-1642-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
* imporve link verification to support version Signed-off-by: Hailong Cui <[email protected]> * imporve link verification to support version Signed-off-by: Hailong Cui <[email protected]> * add breadcrumbs test Signed-off-by: Hailong Cui <[email protected]> * add breadcrumbs test Signed-off-by: Hailong Cui <[email protected]> * fix link with version Signed-off-by: Hailong Cui <[email protected]> * fix test failure Signed-off-by: Hailong Cui <[email protected]> * fix lint Signed-off-by: Hailong Cui <[email protected]> * fix test Signed-off-by: Hailong Cui <[email protected]> * wait for page load complete Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit bd7a18f)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Nov 18, 2024
* imporve link verification to support version Signed-off-by: Hailong Cui <[email protected]> * imporve link verification to support version Signed-off-by: Hailong Cui <[email protected]> * add breadcrumbs test Signed-off-by: Hailong Cui <[email protected]> * add breadcrumbs test Signed-off-by: Hailong Cui <[email protected]> * fix link with version Signed-off-by: Hailong Cui <[email protected]> * fix test failure Signed-off-by: Hailong Cui <[email protected]> * fix lint Signed-off-by: Hailong Cui <[email protected]> * fix test Signed-off-by: Hailong Cui <[email protected]> * wait for page load complete Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit bd7a18f) Co-authored-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.