[workspace] Add integration test cases for workspace assets. #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
SuZhou-Joe
force-pushed
the
feature/workspace_assets_ft
branch
from
454bc3c to
7a355f2
Compare
Hailong-am
approved these changes
Nov 15, 2024
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_assets.spec.js
Outdated
Show resolved
Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_assets.spec.js
Show resolved
Hide resolved
raintygao
reviewed
Nov 15, 2024
| if (Cypress.env('DATASOURCE_MANAGEMENT_ENABLED')) { | ||
| cy.createDataSourceNoAuth().then((result) => { | ||
| datasourceId = result[0]; | ||
| expect(datasourceId).to.be.a('string').that.is.not.empty; |
There was a problem hiding this comment.
Is this used to verify the data source creation successfully?
raintygao
reviewed
Nov 15, 2024
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_assets.spec.js
Show resolved
Hide resolved
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/workspace_assets_ft
branch
from
b4a7ee2 to
c29c2f6
Compare
raintygao
approved these changes
Nov 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 17, 2024
* feat: add functional test for workspace assets Signed-off-by: SuZhou-Joe <[email protected]> * feat: make it compatible with mds case Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize based on comments Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove data sources after test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit ee2fb80)
SuZhou-Joe
added a commit
that referenced
this pull request
Nov 18, 2024
…1648) * feat: add functional test for workspace assets Signed-off-by: SuZhou-Joe <[email protected]> * feat: make it compatible with mds case Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize based on comments Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove data sources after test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit ee2fb80) Co-authored-by: SuZhou-Joe <[email protected]>
ruanyl
reviewed
Nov 18, 2024
| }, | ||
| }) | ||
| .then((resp) => { | ||
| cy.wrap(resp.body.saved_objects).should('have.length', 1); |
There was a problem hiding this comment.
wrap is for making it chainable with an assertion actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integration test cases for workspace assets.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.