Add test cases for workspace creation #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kapian1234
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
wanglam
reviewed
Nov 13, 2024
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_create.spec.js
Show resolved
Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_create.spec.js
Outdated
Show resolved
Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_create.spec.js
Outdated
Show resolved
Hide resolved
wanglam
reviewed
Nov 13, 2024
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_create.spec.js
Outdated
Show resolved
Hide resolved
SuZhou-Joe
approved these changes
Nov 14, 2024
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
SuZhou-Joe
force-pushed
the
workspace_create
branch
from
8bac394 to
a06f04b
Compare
wanglam
approved these changes
Nov 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Update functional tests for workspace create Signed-off-by: Kapian1234 <[email protected]> * Fix duplicate creation Signed-off-by: Kapian1234 <[email protected]> * Add conditions for test cases Signed-off-by: Kapian1234 <[email protected]> * Optimize the condition check Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Co-authored-by: Lin Wang <[email protected]> (cherry picked from commit 840e739)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Update functional tests for workspace create Signed-off-by: Kapian1234 <[email protected]> * Fix duplicate creation Signed-off-by: Kapian1234 <[email protected]> * Add conditions for test cases Signed-off-by: Kapian1234 <[email protected]> * Optimize the condition check Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Co-authored-by: Lin Wang <[email protected]> (cherry picked from commit 840e739) Co-authored-by: Jincheng Wan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.