Add different access level test cases in workspace update flow #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
raintygao,
zhongnansu and
yujin-emma
as code owners
SuZhou-Joe
reviewed
Nov 8, 2024
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_detail.spec.js
Outdated
Show resolved
Hide resolved
ruanyl
reviewed
Nov 8, 2024
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_detail.spec.js
Outdated
Show resolved
Hide resolved
Comment on lines
152
to
157
| let originalUser = ADMIN_AUTH.username; | ||
| let originalPassword = ADMIN_AUTH.password; | ||
| beforeEach(() => { | ||
| originalUser = ADMIN_AUTH.username; | ||
| originalPassword = ADMIN_AUTH.password; | ||
| }); |
There was a problem hiding this comment.
Do we actually need to update originalUser and originalPassword in before each? Shall we simply do a const
Suggested change
| let originalUser = ADMIN_AUTH.username; | |
| let originalPassword = ADMIN_AUTH.password; | |
| beforeEach(() => { | |
| originalUser = ADMIN_AUTH.username; | |
| originalPassword = ADMIN_AUTH.password; | |
| }); | |
| const originalUser = ADMIN_AUTH.username; | |
| const originalPassword = ADMIN_AUTH.password; |
| @@ -4,3 +4,8 @@ | |||
| */ | |||
|
|
|||
| export const WORKSPACE_API_PREFIX = '/api/workspaces'; | |||
|
|
|||
| export const NONE_DASHBOARDS_ADMIN_USER = { | |||
There was a problem hiding this comment.
What about create internal user with command createInternalUser so the workspace tests don't rely on specific user and pass.
There was a problem hiding this comment.
I've tried this way before. But not only do we need to call createInternalUser, we also need to create a role and map the internal user to it too. It will be more complicated.
…boards/workspace-plugin/mds_workspace_detail.spec.js Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Hailong-am
reviewed
Nov 13, 2024
| after(() => { | ||
| cy.deleteWorkspaceById(workspaceId); | ||
| if (Cypress.env('SECURITY_ENABLED')) { | ||
| cy.deleteInternalUser(NONE_DASHBOARDS_ADMIN_USERNAME); |
There was a problem hiding this comment.
should we delete role and role mapping as well?
There was a problem hiding this comment.
It won't fail when creating a role or mapping with the same name. Deleting a user is to protect the system. Will add the remove role logic.
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
SuZhou-Joe
approved these changes
Nov 14, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
Hailong-am
approved these changes
Nov 20, 2024
raintygao
approved these changes
Nov 20, 2024
ruanyl
approved these changes
Nov 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Add test case work different access level in workspace update Signed-off-by: Lin Wang <[email protected]> * Update cypress/integration/core-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_detail.spec.js Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: Lin Wang <[email protected]> * Address PR comments Signed-off-by: Lin Wang <[email protected]> * Replace kibanaserver with self created workspace test user Signed-off-by: Lin Wang <[email protected]> * Delete role after test finish Signed-off-by: Lin Wang <[email protected]> * Delete role mapping Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 7e05a4f)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Nov 22, 2024
#1657) * Add test case work different access level in workspace update Signed-off-by: Lin Wang <[email protected]> * Update cypress/integration/core-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_detail.spec.js Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: Lin Wang <[email protected]> * Address PR comments Signed-off-by: Lin Wang <[email protected]> * Replace kibanaserver with self created workspace test user Signed-off-by: Lin Wang <[email protected]> * Delete role after test finish Signed-off-by: Lin Wang <[email protected]> * Delete role mapping Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 7e05a4f) Co-authored-by: Lin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for adding different access level test cases in workspace update flow
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.