Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases to dashboards maps #1540

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add test cases to dashboards maps #1540

merged 1 commit into from
Aug 30, 2024

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Aug 29, 2024 •
edited
Loading

Description

This PR is going to:

Issues Resolved

opensearch-project/dashboards-maps#663

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@junqiu-lei
Copy link
Member Author

Looks the CI isn't able to start up OpenSearch cluster. The test case passed on my forked repo CI:
https://github.com/junqiu-lei/dashboards-maps/actions/runs/10623549472/job/29450177444?pr=21

yujin-emma
yujin-emma approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@yujin-emma yujin-emma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raintygao raintygao merged commit e06a6f2 into opensearch-project:main Aug 30, 2024
40 of 59 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 30, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
@junqiu-lei @github-actions
Add test cases to dashboards maps (#1540)
73e65bf 
Signed-off-by: Junqiu Lei <[email protected]>
(cherry picked from commit e06a6f2)
raintygao pushed a commit that referenced this pull request Aug 30, 2024
@opensearch-trigger-bot @junqiu-lei
Add test cases to dashboards maps (#1540) (#1541)
b937972 
Signed-off-by: Junqiu Lei <[email protected]>
(cherry picked from commit e06a6f2)

Co-authored-by: Junqiu Lei <[email protected]>
@junqiu-lei junqiu-lei mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujin-emma yujin-emma yujin-emma approved these changes

@raintygao raintygao raintygao approved these changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junqiu-lei @raintygao @yujin-emma