Add functional test for UI Metric #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDrago27
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
|
@LDrago27 Thanks for bringing this up. Is this PR targeting for 2.14? |
|
@SuZhou-Joe These changes are not being targeted for 2.14 release. |
|
will you handle the OSD CI to run these tests? with the new env variable set? |
|
@kavilla I will update the OSD CI to include these tests. However i would like to wait till the changes in opensearch-project/OpenSearch-Dashboards#6721 are reviewed and merged , so that introducing these tests don't break the CIs. |
Merged
7 tasks
Signed-off-by: Suchit Sahoo <[email protected]>
ananzh
approved these changes
Jun 7, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1267-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2e2498789e016cceea4be39fcca539399a20a22
# Push it to GitHub
git push --set-upstream origin backport/backport-1267-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
LDrago27
added a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Suchit Sahoo <[email protected]> (cherry picked from commit b2e2498)
LDrago27
added a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
Jun 8, 2024
Signed-off-by: Suchit Sahoo <[email protected]> (cherry picked from commit b2e2498)
ananzh
pushed a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Suchit Sahoo <[email protected]> (cherry picked from commit b2e2498)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functional tests to validate the UI Metric Collector introduced in OpenSearch dashboards core. This PR is the same as
#1223 wit the updated changes based on comments which got closed by mistake.
Added test cases to validate server side batching of UI Metric reports introduced in opensearch-project/OpenSearch-Dashboards#6721
Tests
ui_metric_no_security.spec.js.mp4
ui_metric_with_security.spec.js.mp4
server_with_Security.spec.js.mp4
server_without_security.spec.js.mp4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.