Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include security-dashboards-plugin folder to CI #1168

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Hailong-am
Copy link
Collaborator

Description

Add folder cypress/integration/plugins/security-dashboards-plugin/* to test command.

Issues Resolved

#1139

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam
Copy link
Collaborator

wanglam commented Mar 22, 2024

@Hailong-am Have you tested the new security workflow work as expected after added the security-dashboards-plugin files? Is there any job details?

@Hailong-am
Copy link
Collaborator Author

@Hailong-am Have you tested the new security workflow work as expected after added the security-dashboards-plugin files? Is there any job details?

Yes, here is the CI run on my fork https://github.com/Hailong-am/opensearch-dashboards-functional-test/actions/runs/8368815176/job/22913945774

Run cypress-io/github-action@v2
  with:
    working-directory: cypress-test
    command: env CYPRESS_NO_COMMAND_LOG=1 yarn cypress:run-with-security --browser chromium --spec 'cypress/integration/plugins/security/*,cypress/integration/plugins/security-dashboards-plugin/*'
    record: false
    config-file: cypress.json

@Hailong-am Hailong-am merged commit 05c66fe into opensearch-project:main Mar 28, 2024
42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 28, 2024
Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 05c66fe)
Hailong-am added a commit that referenced this pull request Mar 28, 2024
Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 05c66fe)

Co-authored-by: Hailong Cui <[email protected]>
LDrago27 pushed a commit to LDrago27/opensearch-dashboards-functional-test that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants