Add GitHub OAuth config #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaiksaya
requested review from
peterzhuamazon,
rishabh6788,
zelinh,
prudhvigodithi and
Divyaasm
as code owners
gaiksaya
commented
Nov 23, 2024
Comment on lines
+79
to
+88
| const githubAuthConfig: { [x: string]: any; } = { | ||
| github: { | ||
| githubWebUri: 'https://github.com', | ||
| githubApiUri: 'https://api.github.com', | ||
| clientID: 'clientID', | ||
| clientSecret: 'clientSecret', | ||
| oauthScopes: 'read:org,user:email', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
The huge diff is due to file name change. Actual diff only applies to these lines and last 5 files of this file.
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
force-pushed
the
add-github-oauth-config
branch
from
0c0e133 to
eb12990
Compare
rishabh6788
reviewed
Nov 25, 2024
README.md
Outdated
| 1. Run with parameter with one of the following (refer [this](#ssl-configuration) for value of `useSsL`) - | ||
| 1. `npm run cdk deploy OpenSearch-CI-Dev -- -c runWithOidc=true -c useSsl=true` or, | ||
| 1. `cdk deploy OpenSearch-CI-Dev -c runWithOidc=true -c useSsl=true` | ||
| 1. `npm run cdk deploy OpenSearch-CI-Dev -- -c authType=oidc/github/default -c useSsl=true` or, |
There was a problem hiding this comment.
nit: oidc|github|default
There was a problem hiding this comment.
Jenkins github is OIDC plugin right?
There was a problem hiding this comment.
They define it as GitHub Auth plugin and it also has a config different that oidc in jenkins.yaml (configuration as code)
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
rishabh6788
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Breaking Change]
This PR replaces
runWithOidcparameter withauthTypeto support multiple authTypes.Defaults to whatever is written in
baseJenkins.yaml.With this change we now support github as auth mechanism.
Issues Resolved
related #506. Will close this issue once we officially adapt this parameter in internal deployments as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.