Adding more JDK support for Jenkins Mac agent nodes #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Lu <[email protected]>
jordarlu
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi and
Divyaasm
as code owners
Signed-off-by: Jeff Lu <[email protected]>
peterzhuamazon
requested changes
Dec 7, 2023
Signed-off-by: Jeff Lu <[email protected]>
Comment on lines
34
to
37
| for d in /Library/Java/JavaVirtualMachines/*/Contents/Home; do | ||
| jenv add "$d" | ||
| done | ||
| jenv global temurin64-11.0.21 |
There was a problem hiding this comment.
Suggestion:
- Change
dto some other better variable name to be more visiable - See if you can make every entry an alias for easier setup, recommending
openjdk-<majorVersion>as that is the output of the javaVersion fromdetectAgentjenkins lib such as:
https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/detectDockerAgent.groovy#L16C27-L16C34
https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L102
Thanks.
There was a problem hiding this comment.
thanks, Peter, looks like jenv did support using the alias per jenv/jenv#306 , so, I am adapting it in revised PR here now.. and we can remove the for-loop
Also, seems like some issues on jdk14, 19, and 20 on my local Mac test, let me remove them for now.
Signed-off-by: Jeff Lu <[email protected]>
peterzhuamazon
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref : https://ports.macports.org/port/openjdk11-temurin/details/
Issues Resolved
A Mac agent build failure on JDK21 (https://build.ci.opensearch.org/blue/organizations/jenkins/publish-opensearch-min-snapshots/detail/publish-opensearch-min-snapshots/432/pipeline) due to a bug (opensearch-project/opensearch-build#4272)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.