Make windows gradle check server using proper amount of memory in WinRM #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
gaiksaya
reviewed
Feb 8, 2023
Comment on lines
+8
to
+18
| $memorygb = [int]$args[0] | ||
| $memorygb | ||
|
|
||
| if ($memorygb) { | ||
| $memorymb = $memorygb * 1024 | ||
| } | ||
| else { | ||
| $memorymb = 30 * 1024 | ||
| } | ||
| cmd /c winrm set "winrm/config/winrs" "@{MaxMemoryPerShellMB=\`"$memorymb\`"}" | ||
| cmd /c winrm get winrm/config |
There was a problem hiding this comment.
Can you please explain this? What it is trying to do?
Thanks!
There was a problem hiding this comment.
It is trying to get user input in GB and convert to MB and apply to WinRM max memory allocation during Jenkins agent node communications.
When Jenkins communicate with Windows node through WinRM it can only allocate the max number of memory in MBs that WinRM allows it to allocate.
This make sure the value is assigned dynamically based on the AMI requirements. Thanks.
gaiksaya
approved these changes
Feb 14, 2023
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-ci
that referenced
this pull request
May 11, 2023
Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu [email protected]
Description
Make windows gradle check server using proper amount of memory in WinRM
Issues Resolved
opensearch-project/opensearch-build-libraries#113
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.