Lower Java version to 11 for OpenSearch 1.3.0. #981
Conversation
Signed-off-by: dblock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
==========================================
+ Coverage 92.78% 92.95% +0.16%
==========================================
Files 89 89
Lines 2385 2385
==========================================
+ Hits 2213 2217 +4
+ Misses 172 168 -4
Continue to review full report at Codecov.
|
| ci: | ||
| image: | ||
| name: "opensearchstaging/ci-runner:centos7-x64-arm64-jdkmulti-node10.24.1-cypress6.9.1-20211028" | ||
| args: "-e JAVA_HOME=/opt/java/openjdk-11" |
There was a problem hiding this comment.
Does this change the integration test environment jdk too?
There was a problem hiding this comment.
Does not today. Because we have never run any automation for integration tests currently it would use whatever JAVA_HOME you have on your machine. When we put that into Jenkins, we'll need to decide what to use. Note that it sort of doesn't matter because you're deploying an OpenSearch cluster with the JVM packaged inside OpenSearch, so if we wanted to test OpenSearch with multiple JVMs, you'd need to produce distributions with different versions of the bundled JVM or swap the JVM before starting any test cluster.
There was a problem hiding this comment.
Note; this is a great example of why I like the integration tests that start up a cluster to be coupled to the build process.. if that is a good enough trade-off is still up for debate.
There was a problem hiding this comment.
Makes sense. One way is to have no-jdk distribution and a jdk matrix to run integration test against.
| ci: | ||
| image: | ||
| name: "opensearchstaging/ci-runner:centos7-x64-arm64-jdkmulti-node10.24.1-cypress6.9.1-20211028" | ||
| args: "-e JAVA_HOME=/opt/java/openjdk-11" |
There was a problem hiding this comment.
Note; this is a great example of why I like the integration tests that start up a cluster to be coupled to the build process.. if that is a good enough trade-off is still up for debate.
|
cc: @reta |
|
This is awesome, thanks @dblock ! 👍 👍 👍 |
Signed-off-by: dblock [email protected]
Description
We've lowered the JDK for OpenSearch to 11 in opensearch-project/OpenSearch#940.
Issues Resolved
Part of #74.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.