Fix build break by attaching jvm image detection to an agent node #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <[email protected]>
|
Can dashboards get it as well? I verified in my own pipeline that adding this will fix the problem for Dashboards too. |
Signed-off-by: Peter Nied <[email protected]>
|
@kavilla Almost fixed it before you noticed :) |
Signed-off-by: Peter Nied <[email protected]>
gaiksaya
approved these changes
Oct 22, 2021
kavilla
approved these changes
Oct 22, 2021
dblock
reviewed
Oct 22, 2021
| agent { | ||
| docker { | ||
| label 'Jenkins-Agent-al2-x64-c54xlarge-Docker-Host' | ||
| image 'opensearchstaging/ci-runner:centos7-x64-arm64-jdk14-node10.24.1-cypress6.9.1-20211005' |
There was a problem hiding this comment.
This is not very important, but we can probably use a minimal image for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attached the jvm detection logic inside of an docker container.
We have a requirement to not run jobs on the main jenkins node for security concerns. We enforce running in a container to keep jobs resource isolated since many build tools use shared system caches/components.
Issues
Testing
Full build with this change under my one-off build pipeline
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.