-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to publish to maven local #743
Conversation
[[ "$SNAPSHOT" == "true" ]] && VERSION=$VERSION-SNAPSHOT | ||
|
||
|
||
cd opensearch-java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think there is a sub-directory called opensearch-java right? Assumption is this script will be run inside opensearch-java so no need to change directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thats correct. I will remove cd opensearch-java
with assumption that this script will be executed inside opensearch-java repository.
Added script for opensearch-java to publish to maven local based on version and whether is it snapshot or not. Signed-off-by: Vijayan Balasubramanian <[email protected]>
233cb95
to
6e2bb9d
Compare
I assume I am missing some context, forgive my naive questions - its 53 lines of code to set 2 variables and execute a gradle command, that seems like a lot for not very much - is there an expectation that this file will grow with other changes? If the design is that Jenkins will be doing the publishing, can we convert this into jenkinsfile? Is there a reason to put this code in the opensearch-build repo instead of in opensearch-java? |
There are going to be 2 jenkins files that will be using this file:
Reason to put it in build.sh so that if anything changes in future, we do not need to make code changes in 2 jenkinsfile |
What else is this script going to do? I don't think you want this "interface" that ends up invoking 1 command, even with different args, at least until the build script becomes super complicated. I vote for just doing it in Jenkinsfile, this way we know what is actually happening by looking at that. Right now that Jenkinsfile would be |
What do we want to do with this @VijayanB? |
This is not required anymore due to opensearch-project/opensearch-java#51 |
Signed-off-by: Vijayan Balasubramanian [email protected]
Description
Added script for opensearch-java to publish to maven local based on
version and whether is it snapshot or not.
Issues Resolved
#585
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.