enable the dashboards-visualizations plugin for opensearch-dashboard bundle build #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er build Signed-off-by: Tengda He <[email protected]>
…h is a hybrid plugin repo, this will be the model for other hybrid plugin to enable Signed-off-by: Tengda He <[email protected]>
Signed-off-by: Tengda He <[email protected]>
Signed-off-by: Tengda He <[email protected]>
Signed-off-by: Tengda He <[email protected]>
Signed-off-by: Tengda He <[email protected]>
Tengda-He
requested review from
dblock,
kavilla,
seraphjiang and
tianleh
and removed request for
dblock
seraphjiang
approved these changes
Oct 13, 2021
tianleh
approved these changes
Oct 13, 2021
|
Thanks! Looking at your commit history you might want to try using |
|
This doesn’t resolve #680 though, did you mean another issue? |
|
sorry it should be #652 I update the PR, thanks for pointing out. |
|
thanks for the 'git rebase' suggestion, will use the 'git rebase upstream/master' cmd next time to clean up the commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable the dashboards-visualizations plugin for opensearch-dashboard bundle build
Issues Resolved
#652
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.