Fixing maven artifacts for 1.1 #703
Conversation
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
build-1.1-scripts
branch
from
e4e869d to
9aca227
Compare
|
|
||
| mkdir -p $OUTPUT/maven/org/opensearch | ||
| ./gradlew publishToMavenLocal -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT | ||
| cp -r ~/.m2/repository/org/opensearch/performanceanalyzer-rca $OUTPUT/maven/org/opensearch |
There was a problem hiding this comment.
If I understand this correctly: This would mean we are not going to publish maven artifacts for Perf-analyzer and Perf-analyzer RCA.
Is the product team ok with it?
cc: @elfisher @stockholmux @ahopp
There was a problem hiding this comment.
Either way we have already released 1.1 so we cannot go and make changes in the artifacts or we'll end up with different ones in maven than what we've released. The only question now is whether these become part of 1.2, or some earlier patch release.
There was a problem hiding this comment.
That makes sense. For 1.2 may lets create an issues for both of these components to onboard if they'd like to have maven artifacts published. This would be lost when we look few weeks from now.
Also this makes me think, we have to automate verifying maven artifacts are published and have the right signatures for every release, make sure all components we expect exist.
There was a problem hiding this comment.
There's an issue on that, #700
There was a problem hiding this comment.
Zero problems with this @saratvemulapalli.
Description
Issues Resolved
Closes #699.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.