Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bundle into OpenSearch and OpenSearch Dashboards. #601

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 24, 2021

Signed-off-by: dblock [email protected]

Description

Followup from #590, refactors bundle classes that differ in ways they install plugins.

Successfully ran this:

./bundle-workflow/build.sh manifests/1.1.0/opensearch-dashboards-1.1.0.yml
./bundle-workflow/assemble.sh artifacts/manifest.yml

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dblock dblock requested a review from owaiskazi19 September 25, 2021 04:12
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me. Thanks for the really great refactor and tests!

@dblock dblock merged commit c3bc5ce into opensearch-project:main Sep 27, 2021
@dblock dblock deleted the refactor-bundle branch September 27, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants