Add smoke tests to the test manifest schema #5127
Conversation
Signed-off-by: Zelin Hao <[email protected]>
zelinh
requested review from
dblock,
peterzhuamazon,
gaiksaya,
rishabh6788,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
src/manifests/test_manifest.py
Outdated
| @@ -36,6 +36,9 @@ class TestManifest(ComponentManifest['TestManifest', 'TestComponents']): | |||
| test-configs: | |||
| - with-security | |||
| - without-security | |||
| smoke-test: | |||
| test-spec: | |||
There was a problem hiding this comment.
Do we want to keep this as test-configs? Similar to integ-test and bwc test?
There was a problem hiding this comment.
I'm thinking it's not technically config? Keep it as test-configs may cause some confusion to users since we don't modify any of the cluster configuration.
src/manifests/test_manifest.py
Outdated
| "smoke-test": { | ||
| "type": "dict", | ||
| "schema": { | ||
| "test-spec": {"type": "list"}, |
There was a problem hiding this comment.
Do we need to use list here? More than 1 spec file for each test?
Sure let me update it to a single string of spec for now. We can enhance later if we really need more. Thanks. |
Signed-off-by: Zelin Hao <[email protected]>
src/manifests/test_manifest.py
Outdated
| @@ -37,8 +37,7 @@ class TestManifest(ComponentManifest['TestManifest', 'TestComponents']): | |||
| - with-security | |||
| - without-security | |||
| smoke-test: | |||
| test-spec: | |||
| - spec.yaml | |||
| test-spec: spec.yaml | |||
There was a problem hiding this comment.
Can we keep it consistent here?
.yaml or .yml?
Thanks.
Signed-off-by: Zelin Hao <[email protected]>
|
@gaiksaya @peterzhuamazon Any final thoughts or concerns before we merge this PR? |
LGTM, thanks. |
Description
Add smoke tests to the test manifest schema
Issues Resolved
#5126
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.