Add specific download path for downloadBuildManifest
#4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prudhvi Godithi <[email protected]>
prudhvigodithi
force-pushed
the
gradle-check
branch
from
2961f82 to
9fcca06
Compare
prudhvigodithi
requested review from
dblock,
peterzhuamazon,
gaiksaya,
rishabh6788,
zelinh,
Divyaasm and
tianleh
as code owners
rishabh6788
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from the initial PR #4921 (to solve the error
Tar arm64: error (touch: cannot touch 'build-manifest.yml': Permission denied)), since thecreateUploadTestReportManifestis hardcoded https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/createUploadTestReportManifest.groovy#L66 to use the$WORKSPACE/test-report.yml, changing the logic via this PR to ensure thetest-report.ymlis generated in$WORKSPACE/test-report.yml.Issues Resolved
Part of opensearch-project/opensearch-metrics#56 and opensearch-project/opensearch-metrics#51
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.