Add option to validate with/without security and new password for latest versions #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divyaasm
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi and
tianleh
as code owners
Signed-off-by: Divya Madala <[email protected]>
peterzhuamazon
requested changes
Jan 27, 2024
Signed-off-by: Divya Madala <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4377 +/- ##
==========================================
+ Coverage 91.35% 91.55% +0.20%
==========================================
Files 190 190
Lines 6197 6214 +17
==========================================
+ Hits 5661 5689 +28
+ Misses 536 525 -11 ☔ View full report in Codecov by Sentry. |
3 tasks
Signed-off-by: Divya Madala <[email protected]>
gaiksaya
reviewed
Feb 6, 2024
Divyaasm
force-pushed
the
addsecurity
branch
2 times, most recently
from
a8ce835 to
e17a5e1
Compare
Signed-off-by: Divya Madala <[email protected]>
There was a problem hiding this comment.
A few more comments and we all good @Divyaasm .
Significant improvement over the last revision
Thanks!
Signed-off-by: Divya Madala <[email protected]>
peterzhuamazon
approved these changes
Feb 9, 2024
|
Thanks for following the best practice and improve code quality! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to existing validation workflow
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.