Fix deb/rpm integTest not install distribution correctly due to 2.12 security changes #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
added
bug
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
peterzhuamazon
changed the title
…security changes Signed-off-by: Peter Zhu <[email protected]>
prudhvigodithi
approved these changes
Jan 26, 2024
peterzhuamazon
force-pushed
the
integ-test-2.12
branch
from
64439f7 to
3425c91
Compare
gaiksaya
reviewed
Jan 26, 2024
| 'sudo', | ||
| 'dpkg', | ||
| '--purge', | ||
| self.filename, | ||
| '&&', | ||
| 'sudo', | ||
| 'env', | ||
| 'OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123!', |
There was a problem hiding this comment.
What about versions less than 2.12.0? Maybe use get_password here similar to https://github.com/opensearch-project/opensearch-build/pull/4334/files#diff-68a045772f64ada86fcfd23d4e6685b142ed16c1c92ff159601592797e8d4bceR90
There was a problem hiding this comment.
@gaiksaya versions less than 2.12.0 will not get affected at all.
Because they dont even care about this env var.
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4376 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 190 190
Lines 6197 6197
=======================================
Hits 5661 5661
Misses 536 536 ☔ View full report in Codecov by Sentry. |
88 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix deb/rpm integTest not install distribution correctly due to 2.12 security changes
Issues Resolved
#4370
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.