Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and enable triggering integ-test for RPM, debian and windows #4368

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jan 24, 2024

Description

  1. Refactors triggering the integ-test and RPM validation workflow by reducing the code duplication
  2. Enables integ-test for RPM, debian and Windows

Issues Resolved

resolves #2994

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya gaiksaya changed the title Refactor triggering integ-test and enable for RPM, debian and windows Refactor and enable triggering integ-test for RPM, debian and windows Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fec0355) 91.35% compared to head (98522f7) 91.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4368   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         190      190           
  Lines        6175     6175           
=======================================
  Hits         5641     5641           
  Misses        534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaiksaya gaiksaya marked this pull request as draft January 24, 2024 00:34
@gaiksaya gaiksaya marked this pull request as ready for review January 24, 2024 02:30
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any similar changes to the osd as well?

@peterzhuamazon
Copy link
Member

And please do a clean rebase if possible, thanks.

@gaiksaya
Copy link
Member Author

Is there any similar changes to the osd as well?

I'll check that once this is merged and enable the same for OSD

@gaiksaya
Copy link
Member Author

And please do a clean rebase if possible, thanks.

Done! Thanks!

@gaiksaya gaiksaya merged commit 685f23a into opensearch-project:main Jan 24, 2024
12 checks passed
@gaiksaya gaiksaya deleted the enable-rpm-debian branch January 24, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META] RPM, Deb and Windows integration testing lacks jenkins automation
2 participants