-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change password based on version in integtest health check #4331
Conversation
Signed-off-by: Derek Ho <[email protected]>
@prudhvigodithi I also found a reference here: https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/perf_test/perf_test_cluster.py#L115, does this need to be changed as well? |
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4331 +/- ##
==========================================
+ Coverage 91.27% 91.34% +0.07%
==========================================
Files 189 189
Lines 6163 6169 +6
==========================================
+ Hits 5625 5635 +10
+ Misses 538 534 -4 ☔ View full report in Codecov by Sentry. |
Yes this should be updated for 2.12.0 perf tests. |
I don;t think perf test are used anymore. But you can update and keep. For benchmark test module, the changes were in via #4306 |
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Thanks folks! I made the requested changes, can you take another look? |
Groovy test failure seems to be due to network failure |
Hey @derek-ho Codecov is failing can you please check.
|
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Description
The current cluster health endpoint check is always using "admin:admin", this fails on > 2.12.0 since they are starting to be spun up with "admin:myStrongPassword123!". This PR makes that change in the cluster health endpoint.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.