-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common-utils 1.1 branch for OpenSearch 1.1 #430
Conversation
PR Merged: opensearch-project/common-utils#67 |
@VachaShah If possible, Can you also provide me with more context on the failure so that I can double check and be completely sure, if the build failure is fully addressed by this opensearch-project/common-utils#67 PR. |
@aditjind I think #410 was the issue. May be @peternied can elaborate here? |
I've updated the repro steps on #410, copied the reproduction steps into this PR for validation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to wait on opensearch-project/common-utils#65 to be before it can be merged
I'd like to wait for #414 to get merged too so we can verify that this properly fails rn. |
e50636f
Well, CI did catch a bug! opensearch-project/common-utils#69 should fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is managing final approve now, great work @dblock
I re-ran the checks after opensearch-project/common-utils#69 and we're good to go. |
Description
Change to use the 1.1 branch of Common Utils in the 1.1 manifest file.
Issues Resolved
opensearch-project/common-utils#64
PR (opensearch-project/common-utils#65) with all the commits cherry picked from the main branch. We can keep this PR as an artifact.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.