-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve securityDashboards not correctly removed on DEB/RPM #3525
Merged
peterzhuamazon
merged 3 commits into
opensearch-project:main
from
peterzhuamazon:osd_integtest_remove_osd_security_plugin
May 17, 2023
Merged
Resolve securityDashboards not correctly removed on DEB/RPM #3525
peterzhuamazon
merged 3 commits into
opensearch-project:main
from
peterzhuamazon:osd_integtest_remove_osd_security_plugin
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
May 17, 2023 00:08
prudhvigodithi
approved these changes
May 17, 2023
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3525 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 181 181
Lines 5340 5342 +2
=======================================
+ Hits 4868 4870 +2
Misses 472 472
|
After this patch:
|
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve securityDashboards not correctly removed on DEB/RPM.
If
sudo
is not applied to DEB/RPM plugin removal, the run will still goes to success and return 0, despite the plugin directory is still there.Issues Resolved
#3331
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.