-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 1.3.10] Onboard test manifests and add remaining components #3514
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3514 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 181 181
Lines 5340 5340
=======================================
Hits 4868 4868
Misses 472 472 |
- name: functionalTestDashboards | ||
integ-test: | ||
test-configs: | ||
- with-security | ||
- without-security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have changed the way we run dashboards test run so this should change to per component. @Divyaasm can add more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example: https://github.com/Divyaasm/opensearch-build/blob/ghissue/manifests/2.6.0/opensearch-dashboards-2.6.0-test.yml
Not sure if the dashboards repo had backported the running in parallel part for 1.3 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, referring to that link and from what I understood we only need to add the components part of opensearch-dashboards-1.3.10.yml
except for the functionalTestDashboards
. Updated the change in my latest commit. However the backport of this PR opensearch-project/opensearch-dashboards-functional-test#644 should be done to 1.3
to run the OSD integ tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! This PR needs to be backported too opensearch-project/opensearch-dashboards-functional-test#234
Added cross-cluster-replication as the existing version increment PR is merged. |
c339a83
to
1d76924
Compare
Signed-off-by: Prudhvi Godithi <[email protected]>
Noticed one more change with CI image from |
Description
Onboard test manifests and add remaining components.
NOTE: missing CCR due to pending version increment PR opensearch-project/cross-cluster-replication#743
Issues Resolved
Part of #3331
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.