Move old manifests to legacy

[gaiksaya]

Description

Moves some old version manifests to legacy manifest folder

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #3473 (8520ea0) into main (aec6965) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3473   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         181      181           
  Lines        5268     5268           
=======================================
  Hits         4837     4837           
  Misses        431      431           

[peterzhuamazon]

So the only thing that is not legacy is the latest version?

[gaiksaya]

So the only thing that is not legacy is the latest version?

Kept few more for reference in manifests folder along with latest version. Here is the list https://github.com/gaiksaya/opensearch-build/tree/ml/manifests

[gaiksaya]

Looks like 3.0.0 manifest check is failing for multiple components such as ml-commons, neural-search, k-NN. Should we disable CI checks for 3.0.0 OS manifest?
@bbarani @dblock @prudhvigodithi @peterzhuamazon

[dblock]

Looks like 3.0.0 manifest check is failing for multiple components such as ml-commons, neural-search, k-NN. Should we disable CI checks for 3.0.0 OS manifest? @bbarani @dblock @prudhvigodithi @peterzhuamazon

No, we should be fixing the issues!

[jmazanec15]

For k-NN, we are in process of fixing our CI. Problem is there were a couple breaks that have caused a bit of a tangle up in the k-NN CI.

The jackson/gradle upgrade (opensearch-project/OpenSearch#7300) and immutable maps removal (opensearch-project/OpenSearch#7309) have broken a few things. We raised this PR: opensearch-project/k-NN#885. However, CI is failing for secure test because the docker distribution has yet to be updated due to the jackson/gradle issue (circular). Additionally, BWC tests are failing because k-NN 2.8 has not been added to distribution yet (#3472). neural-search is stuck because it depends on k-NN.

In the long term, I believe solution is for plugins to not take dependencies on distribution for secure tests and bwc tests - instead, depend on opensearch-core min artifact and individual dependent plugin artifacts. I think this will break the circular CI dependency chain mentioned above.

In the meantime, for k-NN, I would like to merge this: #3472 so that BWC tests can pass. Then merge opensearch-project/k-NN#885 to unblock distro build and then fix neural search.

[gaiksaya]

In that case just moving the old manifests to legacy for now. 3.0.0 will remain broken until plugin teams fix the issue.
Thanks!