Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Jenkins workflow for build packer. #3368

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Apr 4, 2023

Description

Add new Jenkins workflow for packer build to create new ami.

Issues Resolved

opensearch-project/opensearch-ci#258

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add assertion test cases confirming what needs to be called.

jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #3368 (dafe408) into main (7cd2ad7) will decrease coverage by 0.29%.
The diff coverage is n/a.

❗ Current head dafe408 differs from pull request most recent head 2278976. Consider uploading reports for the commit 2278976 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3368      +/-   ##
==========================================
- Coverage   91.74%   91.46%   -0.29%     
==========================================
  Files         172      172              
  Lines        4991     4991              
==========================================
- Hits         4579     4565      -14     
- Misses        412      426      +14     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zelinh
Copy link
Member Author

zelinh commented Apr 5, 2023

Please add assertion test cases confirming what needs to be called.

Added the assertions for the commands being called.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Have a question and a nit.
Thanks!

jenkins/packer/packer-build.jenkinsfile Show resolved Hide resolved
tests/jenkins/TestPackerBuild.groovy Show resolved Hide resolved
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zelinh ,

Please check comments.

Thanks.

jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
jenkins/packer/packer-build.jenkinsfile Outdated Show resolved Hide resolved
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as the role of packer is required.

@zelinh zelinh force-pushed the packer-build branch 3 times, most recently from 9f3f0ad to f032ced Compare April 10, 2023 18:23
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block for now as we need to verify the length of macos build.
It might take over an hour to build which means the default role assume time of 1hr is not enough.

Thanks.

Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
@peterzhuamazon
Copy link
Member

We have confirmed all the amis can be built within 1 hr.

@peterzhuamazon peterzhuamazon merged commit ea4cb8f into opensearch-project:main Apr 12, 2023
@peterzhuamazon peterzhuamazon deleted the packer-build branch April 12, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants