Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observability, reporting, query workbench and gantt chart to manifests #3048

Merged
merged 6 commits into from
Jan 9, 2023

Conversation

mengweieric
Copy link
Contributor

Description

Add observability, reporting and gantt chart to manifests

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mengweieric mengweieric requested a review from a team as a code owner January 5, 2023 23:02
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #3048 (0fbc29f) into main (af1be01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3048   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         167      167           
  Lines        4602     4602           
=======================================
  Hits         4288     4288           
  Misses        314      314           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Eric Wei <[email protected]>
@@ -108,7 +108,6 @@ components:
platforms:
- linux
- windows
working_directory: opensearch-observability
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we removed all front end folders in this repo and make it exclusive for backend? If not, removing the working_directory may cause build failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a PR ready to merge which removes all front end stuff, will get it merged soon

repository: https://github.com/opensearch-project/dashboards-observability.git
ref: 2.x
- name: reportsDashboards
repository: https://github.com/opensearch-project/dashboards-reporting.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is still not public yet therefore cause the manifest CI checks failed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is public now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zelinh Can you please re-run the failing tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mengweieric Could you rebase to resolve the conflicts?

@zelinh zelinh force-pushed the add-insight-manifests branch from c559908 to d840b15 Compare January 7, 2023 01:58
@mengweieric mengweieric force-pushed the add-insight-manifests branch from d840b15 to 3aad1a5 Compare January 8, 2023 23:40
@mengweieric mengweieric changed the title Add observability, reporting and gantt chart to manifests Add observability, reporting, query workbench and gantt chart to manifests Jan 9, 2023
@zelinh
Copy link
Member

zelinh commented Jan 9, 2023

CI is failing as OpenSearch has bumped to 2.6.0 for 2.x branch. Will need to rebase after this PR merged. #3059

@anirudha
Copy link
Contributor

anirudha commented Jan 9, 2023

@peterzhuamazon @zelinh can we review and merge this soon ?

@zelinh
Copy link
Member

zelinh commented Jan 9, 2023

@peterzhuamazon @zelinh can we review and merge this soon ?

@anirudha Yes, once the CI checks completed, I could help merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants