Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification to 3.0.0 manifest #3033

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Dec 27, 2022

Signed-off-by: bowenlan-amzn [email protected]

Description

Notification main branch has been bumped to 3.0.0. opensearch-project/notifications#556

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #3033 (5bfbc20) into main (ec38440) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3033   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         167      167           
  Lines        4602     4602           
=======================================
  Hits         4288     4288           
  Misses        314      314           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review December 27, 2022 05:15
@bowenlan-amzn bowenlan-amzn requested a review from a team as a code owner December 27, 2022 05:15
@prudhvigodithi
Copy link
Member

prudhvigodithi commented Dec 27, 2022

I have noticed 2.4.1 manifest check fail https://github.com/opensearch-project/opensearch-build/actions/runs/3785280517/jobs/6435218730

Error

ci_workflow.ci_check_list_source_ref.MissingRefError: Missing https://github.com/opensearch-project/dashboards-observability.git@tags/2.4.1.0.

This is because dashboards-observability repo did not create tag 2.4.1.0.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason for the test failure is the recent separations for these repos. More details to track. #3005
We only created tag for the previous observability repo and just flip dashboards-observability public recently.

@peterzhuamazon
Copy link
Member

I think the reason for the test failure is the recent separations for these repos. More details to track. #3005 We only created tag for the previous observability repo and just flip dashboards-observability public recently.

As @zelinh mentioned this is due to the renaming of the repos.
I am ok to merge this PR as the error is not related.
But we do need to resolve the 2.4.1 manifest errors / issues soon. Thanks.

@prudhvigodithi
Copy link
Member

Merging this PR to unblock notifications for 3.0.0.
Thank you

@prudhvigodithi prudhvigodithi merged commit 3a0fa7a into opensearch-project:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants