-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification to 3.0.0 manifest #3033
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3033 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 167 167
Lines 4602 4602
=======================================
Hits 4288 4288
Misses 314 314 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: bowenlan-amzn <[email protected]>
I have noticed 2.4.1 manifest check fail https://github.com/opensearch-project/opensearch-build/actions/runs/3785280517/jobs/6435218730 Error
This is because dashboards-observability repo did not create tag 2.4.1.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason for the test failure is the recent separations for these repos. More details to track. #3005
We only created tag for the previous observability
repo and just flip dashboards-observability
public recently.
As @zelinh mentioned this is due to the renaming of the repos. |
Merging this PR to unblock notifications for 3.0.0. |
Signed-off-by: bowenlan-amzn [email protected]
Description
Notification main branch has been bumped to 3.0.0. opensearch-project/notifications#556
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.