Add reporting to 2.4.0 manifest #2715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
peterzhuamazon
requested changes
Oct 11, 2022
There was a problem hiding this comment.
Hi @rupal-bq please add - windows under - linux for reports scheduler.
Thanks.
Signed-off-by: Rupal Mahajan <[email protected]>
Hi @peterzhuamazon, I added |
peterzhuamazon
approved these changes
Oct 11, 2022
Signed-off-by: Rupal Mahajan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2715 +/- ##
=======================================
Coverage 94.10% 94.10%
=======================================
Files 156 156
Lines 4208 4208
=======================================
Hits 3960 3960
Misses 248 248 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@rupal-bq please remove the newline at the end of file as it is calling linting errors. |
|
And ignore groovy issues it is not related to your changes. |
|
DCO needs to be fixed |
|
Discarding this PR, created #2726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding reporting 2.x branch to 2.4.0 manifest
Issues Resolved
#396
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.