Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ml-commons to manifest 1.3.6 #2683

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

Zhangxunmt
Copy link
Contributor

Signed-off-by: Xun Zhang [email protected]

Description

add ml-commons to manifest 1.3.6

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt requested a review from a team as a code owner September 30, 2022 22:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #2683 (38b7ee5) into main (55b2622) will not change coverage.
The diff coverage is n/a.

❗ Current head 38b7ee5 differs from pull request most recent head 84d7dfb. Consider uploading reports for the commit 84d7dfb to get more accurate results

@@           Coverage Diff           @@
##             main    #2683   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         156      156           
  Lines        4208     4208           
=======================================
  Hits         3960     3960           
  Misses        248      248           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need #2674 to be merged first before this as PA is currently blocking ml-commons.

Signed-off-by: Zelin Hao <[email protected]>
@ylwu-amzn
Copy link
Contributor

@zelinh PR #2674 merged, can you help merge this PR?

@zelinh
Copy link
Member

zelinh commented Oct 3, 2022

Merge this as the groovy tests failure is expected and not related to this PR.

@zelinh zelinh merged commit f099705 into opensearch-project:main Oct 3, 2022
monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
Signed-off-by: Xun Zhang <[email protected]>

Signed-off-by: Xun Zhang <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
Co-authored-by: Zelin Hao <[email protected]>
Signed-off-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants