Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix match_function link syntax in 2.1.0 release notes #2385

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Fix match_function link syntax in 2.1.0 release notes #2385

merged 1 commit into from
Jul 29, 2022

Conversation

mykhal
Copy link
Contributor

@mykhal mykhal commented Jul 29, 2022

The doc states

… including [match_function](https://github.com/opensearch-project/sql/pull/204], …

instead of

… including match_function, …

@mykhal mykhal requested a review from a team as a code owner July 29, 2022 14:36
@gaiksaya
Copy link
Member

gaiksaya commented Jul 29, 2022

Hi @mykhal Thanks for the fix, Can you sign your commit so it passes the DCO check?
Thanks!

@mykhal
Copy link
Contributor Author

mykhal commented Jul 29, 2022

@gaiksaya thanks for noticing, signing fixed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #2385 (9b50278) into main (556defb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2385   +/-   ##
=========================================
  Coverage     94.61%   94.62%           
  Complexity       27       27           
=========================================
  Files           209      209           
  Lines          4309     4316    +7     
  Branches         29       29           
=========================================
+ Hits           4077     4084    +7     
  Misses          226      226           
  Partials          6        6           
Impacted Files Coverage Δ
src/manifests_workflow/input_manifests.py 99.04% <0.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@gaiksaya gaiksaya merged commit 71cead6 into opensearch-project:main Jul 29, 2022
@mykhal mykhal deleted the rel-2.1.0-notes-link-syntax-fix branch July 29, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants