Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2.6.0 Ruby and tweak jdk tool naming to be consistent with docker images #2365

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jul 25, 2022

Signed-off-by: Peter Zhu [email protected]

Description

Use 2.6.0 Ruby and tweak jdk tool naming to be consistent with docker images

Issues Resolved

Part of #2365, #2364

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added the enhancement New Enhancement label Jul 25, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner July 25, 2022 20:02
@peterzhuamazon peterzhuamazon self-assigned this Jul 25, 2022
@prudhvigodithi
Copy link
Member

Hey @peterzhuamazon should this new dockerImages be part of any jenkinsfile?

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #2365 (e4bf6de) into main (ffe2328) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2365   +/-   ##
=========================================
  Coverage     94.61%   94.61%           
  Complexity       27       27           
=========================================
  Files           209      209           
  Lines          4309     4309           
  Branches         29       29           
=========================================
  Hits           4077     4077           
  Misses          226      226           
  Partials          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@peterzhuamazon
Copy link
Member Author

Hey @peterzhuamazon should this new dockerImages be part of any jenkinsfile?

@prudhvigodithi this is not major changes thus we will create v2.x version then map them back to v2.
Therefore we preserve the old image while no need to change tags.

@peterzhuamazon
Copy link
Member Author

Pause on merging will only merge once images are created.

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon merged commit e1ec070 into opensearch-project:main Jul 26, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-update-ci-dockers branch July 26, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants