Add addition Whitesource offline scan on 1.3 branch #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2032 +/- ##
=========================================
Coverage 94.23% 94.23%
Complexity 25 25
=========================================
Files 198 198
Lines 3902 3902
Branches 29 29
=========================================
Hits 3677 3677
Misses 219 219
Partials 6 6 Continue to review full report at Codecov.
|
tianleh
reviewed
Apr 23, 2022
| @@ -1,7 +1,7 @@ | |||
| pipeline { | |||
| agent none | |||
| options { | |||
| timeout(time: 5, unit: 'HOURS') | |||
| timeout(time: 7, unit: 'HOURS') | |||
There was a problem hiding this comment.
just curious why this is changed
There was a problem hiding this comment.
@tianleh We used to run scan on main branches and this PR is to add 1.3 branch along with main branch. I assume the time should be doubled. I changed it to 7 hours so far and will need to increase it if it's not enough.
tianleh
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add addition Whitesource offline scan on 1.3 branch along with the main branch as we will be still supporting on the 1.3 branch after we moved to 2.0.
Issues Resolved
#2027
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.