Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifier support for ci workflows in build repo #1867

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Mar 30, 2022

Description

Add qualifier support for ci workflows in build repo
Additional improvement in: opensearch-project/OpenSearch-Dashboards#1486

Issues Resolved

Part of #1632
closes #1839

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #1867 (70d60e5) into main (833d892) will increase coverage by 5.46%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     opensearch-project/opensearch-build#1867      +/-   ##
=============================================
+ Coverage     94.53%   100.00%   +5.46%     
=============================================
  Files           178         6     -172     
  Lines          3625       105    -3520     
  Branches         27        19       -8     
=============================================
- Hits           3427       105    -3322     
+ Misses          194         0     -194     
+ Partials          4         0       -4     
Impacted Files Coverage Δ
src/ci_workflow/ci_check_gradle_dependencies.py
src/ci_workflow/ci_check_gradle_properties.py
...workflow/ci_check_gradle_publish_to_maven_local.py
src/ci_workflow/ci_check_npm_package_version.py
src/ci_workflow/ci_input_manifest.py
src/ci_workflow/ci_target.py
...c/test_workflow/dependency_installer_opensearch.py
src/manifests/build_manifest.py
tests/jenkins/jobs/BuildDockerImage_Jenkinsfile
tests/jenkins/jobs/UploadToS3_Jenkinsfile
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833d892...70d60e5. Read the comment docs.

@peterzhuamazon peterzhuamazon merged commit 3d2011e into opensearch-project:main Mar 31, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-ci-qualifier branch March 31, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Need to add qualifier suppport for ci_workflow
3 participants