Add wget for fetching manifests #1685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kunal Kotwani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1685 +/- ##
=========================================
Coverage 94.74% 94.74%
Complexity 14 14
=========================================
Files 166 166
Lines 3501 3504 +3
Branches 25 26 +1
=========================================
+ Hits 3317 3320 +3
Misses 181 181
Partials 3 3
Continue to review full report at Codecov.
|
|
I was suggested to use curl so I have a PR that modifies that script. Comment: #1653 (comment) |
peterzhuamazon
requested changes
Mar 2, 2022
|
@kotwanikunal, the script has been updated to use curl. please rebase and see if this resolves your issues. |
This resolves my issues. Thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kunal Kotwani [email protected]
Description
wgetas a normal dependency to fetch bundle manifests for performance testsIssues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.