Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the type checking for CI workflow #1678

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Mar 1, 2022

Signed-off-by: Zelin Hao [email protected]

Description

There aren't much else to fix for the type checking on CI-workflw.

The usage of Any is necessary for the rest of the circumstances because of the testing we had; attributes certain types like Component or InputManifest don't have or the existing checks inside the code block (e.g. ci_check_lists).

Issues Resolved

This continues on the previous #1582 and improve based on that.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner March 1, 2022 02:03
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #1678 (58078cb) into main (2064d4f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1678   +/-   ##
=========================================
  Coverage     94.61%   94.61%           
  Complexity       14       14           
=========================================
  Files           165      165           
  Lines          3471     3471           
  Branches         21       21           
=========================================
  Hits           3284     3284           
  Misses          184      184           
  Partials          3        3           
Impacted Files Coverage Δ
src/ci_workflow/ci_manifests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2064d4f...58078cb. Read the comment docs.

@zelinh
Copy link
Member Author

zelinh commented Mar 1, 2022

@gaiksaya
Copy link
Member

gaiksaya commented Mar 1, 2022

Can you add the path here: https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/python-tests.yml#L35?

It has been included there.

I see! This PR was the one #1582
Thanks!

@zelinh zelinh requested a review from gaiksaya March 1, 2022 02:37
@gaiksaya gaiksaya merged commit 9cb1ffb into opensearch-project:main Mar 1, 2022
@gaiksaya
Copy link
Member

gaiksaya commented Mar 1, 2022

@zelinh zelinh deleted the small-fix-ci branch March 1, 2022 19:21
@zelinh
Copy link
Member Author

zelinh commented Mar 1, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python Typechecking] CI workflow pipenv run mypy src\ci_workflow tests\tests_ci_workflow
4 participants