-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the type checking for CI workflow #1678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the path here: https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/python-tests.yml#L35?
Signed-off-by: Zelin Hao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1678 +/- ##
=========================================
Coverage 94.61% 94.61%
Complexity 14 14
=========================================
Files 165 165
Lines 3471 3471
Branches 21 21
=========================================
Hits 3284 3284
Misses 184 184
Partials 3 3
Continue to review full report at Codecov.
|
It has been included there. |
I see! This PR was the one #1582 |
Hi @zelinh , there is a failing test https://github.com/opensearch-project/opensearch-build/runs/5380201785?check_suite_focus=true |
Seems like it's good now. |
Signed-off-by: Zelin Hao [email protected]
Description
There aren't much else to fix for the type checking on CI-workflw.
The usage of
Any
is necessary for the rest of the circumstances because of the testing we had; attributes certain types likeComponent
orInputManifest
don't have or the existing checks inside the code block (e.g.ci_check_lists
).Issues Resolved
This continues on the previous #1582 and improve based on that.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.