Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test manifest for OpenSearch Dashboards 1.3.0 #1658

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

tianleh
Copy link
Member

@tianleh tianleh commented Feb 19, 2022

Signed-off-by: Tianle Huang [email protected]

Description

This test manifest was previously removed by #1470 when OSD 1.3.0 was to be replaced by OSD 2.0.0

Looks like now we are releasing OSD 1.3.0 https://github.com/opensearch-project/opensearch-build/blob/main/manifests/1.3.0/opensearch-dashboards-1.3.0.yml

Thus add back this test manifest file. Dashboards plugin teams are actively onboarding on to the FTRepo opensearch-project/opensearch-dashboards-functional-test#72

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tianleh tianleh requested a review from a team as a code owner February 19, 2022 20:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #1658 (c3f0a4c) into main (947bc5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1658   +/-   ##
=========================================
  Coverage     94.69%   94.69%           
  Complexity       14       14           
=========================================
  Files           163      163           
  Lines          3447     3447           
  Branches         21       21           
=========================================
  Hits           3264     3264           
  Misses          180      180           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947bc5d...c3f0a4c. Read the comment docs.

@tianleh
Copy link
Member Author

tianleh commented Feb 21, 2022

See this check failure.
https://github.com/opensearch-project/opensearch-build/runs/5279350076?check_suite_focus=true

This is related to ./ci.sh manifests/1.3.0/opensearch-1.3.0.yml --snapshot which is irrelevant of this PR.

@tianleh
Copy link
Member Author

tianleh commented Feb 21, 2022

Created a bug #1661

Signed-off-by: Tianle Huang <[email protected]>
Signed-off-by: Tianle Huang <[email protected]>
@tianleh
Copy link
Member Author

tianleh commented Feb 25, 2022

After merging the latest main branch, all checks are successful. Could you @gaiksaya @zelinh please help click the merge button?

@abhinavGupta16 abhinavGupta16 merged commit 82e64a9 into opensearch-project:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants