-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Unify code for all things that are used for a build #2609
Comments
I believe this was supposed to be python code from the start, I did comment on the PR that added some of this #1912 (comment) but looks like it was ignored/missed. Added as bug as today we cannot run/test this code locally. |
New links for above libraries: https://github.com/opensearch-project/opensearch-build-libraries/tree/main/vars |
We should consider moving all validation groovy code to the validation workflow https://github.com/opensearch-project/opensearch-build/tree/main/src/validation_workflow. |
Describe the bug
It is observed during the separation task of CI libraries (issue #2489) that the code in this repo is split into 2 process. Building components and CI libraries (for uploading, releasing, etc) that integrates and runs with CI system (Jenkins)
However, looks like few of them have mixed up.
For example:
https://github.com/opensearch-project/opensearch-build/blob/main/vars/buildYumRepo.groovy
https://github.com/opensearch-project/opensearch-build/blob/main/vars/rpmMetaValidation.groovy
https://github.com/opensearch-project/opensearch-build/blob/main/vars/rpmDistValidation.groovy
https://github.com/opensearch-project/opensearch-build/blob/main/vars/rpmDashboardsDistValidation.groovy
More ....
The above snippets cannot be run independently as a code but needs to be run as a part of CI.
All of them should be run as a python code. A wrapper can be used to run them as a part of CI system like integ-test but they should run independently and locally too and not dependent on any CI
To reproduce
No way to run the above code independently
Expected behavior
No response
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response
Acceptance Criteria:
The text was updated successfully, but these errors were encountered: