Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unify code for all things that are used for a build #2609

Open
gaiksaya opened this issue Sep 13, 2022 · 6 comments
Open

[Bug]: Unify code for all things that are used for a build #2609

gaiksaya opened this issue Sep 13, 2022 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Sep 13, 2022

Describe the bug

It is observed during the separation task of CI libraries (issue #2489) that the code in this repo is split into 2 process. Building components and CI libraries (for uploading, releasing, etc) that integrates and runs with CI system (Jenkins)
However, looks like few of them have mixed up.
For example:
https://github.com/opensearch-project/opensearch-build/blob/main/vars/buildYumRepo.groovy
https://github.com/opensearch-project/opensearch-build/blob/main/vars/rpmMetaValidation.groovy
https://github.com/opensearch-project/opensearch-build/blob/main/vars/rpmDistValidation.groovy
https://github.com/opensearch-project/opensearch-build/blob/main/vars/rpmDashboardsDistValidation.groovy
More ....

The above snippets cannot be run independently as a code but needs to be run as a part of CI.

All of them should be run as a python code. A wrapper can be used to run them as a part of CI system like integ-test but they should run independently and locally too and not dependent on any CI

To reproduce

No way to run the above code independently

Expected behavior

No response

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

Acceptance Criteria:

  • Identify the right groovy code that needs to be migrated to python code in the build repo.
  • If the existing validation workflow part of the build repo can validate, then remove the groovy code that does the validation ([Bug]: Unify code for all things that are used for a build #2609 (comment)).
  • Identify the groovy libs that are outdated and remove them from being used in the workflows.
@gaiksaya gaiksaya added bug Something isn't working untriaged Issues that have not yet been triaged labels Sep 13, 2022
@bbarani bbarani removed the untriaged Issues that have not yet been triaged label Sep 15, 2022
@prudhvigodithi
Copy link
Member

@gaiksaya @bbarani this is more of a feature to convert into a python code and use them as part of the existing workflows rather than a bug. wdyt?

@gaiksaya
Copy link
Member Author

gaiksaya commented Sep 20, 2022

I believe this was supposed to be python code from the start, I did comment on the PR that added some of this #1912 (comment) but looks like it was ignored/missed. Added as bug as today we cannot run/test this code locally.
Further more if we add validations for Deb, macos, windows, I believe this should not be the path we choose. Better to have a validation framework that extends for each distribution, architecture

@gaiksaya
Copy link
Member Author

@jordarlu
Copy link
Contributor

Hi, @gaiksaya , as #2725 has been merged, do you think we can close this issue? thanks!

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Nov 13, 2023

We should consider moving all validation groovy code to the validation workflow https://github.com/opensearch-project/opensearch-build/tree/main/src/validation_workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants