Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] Release version 1.3.5 #2348

Closed
32 of 35 tasks
github-actions bot opened this issue Jul 19, 2022 · 24 comments · Fixed by opensearch-project/security#2042 or opensearch-project/security-dashboards-plugin#1078
Closed
32 of 35 tasks
Assignees

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022

Release OpenSearch and OpenSearch Dashboards 1.3.5

I noticed that a manifest was automatically created in manifests/1.3.5. Please follow the following checklist to make a release.

How to use this issue

This Release Issue

This issue captures the state of the OpenSearch release, its assignee is responsible for driving the release. Please contact them or @mention them on this issue for help. There are linked issues on components of the release where individual components can be tracked. More details are included in the Maintainers Release owner section.

Release Steps

There are several steps to the release process, these steps are completed as the whole release and components that are behind present risk to the release. The release owner completes the tasks in this ticket, whereas component owners resolve tasks on their ticket in their repositories.

Steps have completion dates for coordinating efforts between the components of a release; components can start as soon as they are ready far in advance of a future release.

Component List

To aid in understanding the state of the release there is a table with status indicating each component state. This is updated based on the status of the component issues.

Preparation

  • Assign this issue to a release owner.
  • Declare a pencils down date for new features to be merged.
  • August 16th, 2022 is pencils down date for feature freeze.
  • Update the Campaigns section to include monitoring campaigns during this release.
  • Update this issue so all __REPLACE_RELEASE-__ placeholders have actual dates.
  • Document any new quality requirements or changes.
  • Finalize scope and feature set and update the Public Roadmap.
  • Create a release issue in every component repo that links back to this issue, update Components section with these links.
  • Ensure the label is created in each component repo for this new version, and the next minor release. Create a version label
  • Ensure that all release issues created above are assigned to an owner in the component team.

### CI/CD (Feature Freeze) - August 16th, 2022

CI/CD (Feature Freeze) - August 19th, 2022

  • Create Jenkins workflows that run daily snapshot builds for OpenSearch and OpenSearch Dashboards.
  • Increment each component version to 1.3.5 and ensure working CI in component repositories.
  • Make pull requests to add each component to manifests/1.3.5/opensearch-1.3.5.yml and manifests/1.3.5/opensearch-dashboards-1.3.5.yml with the corresponding checks.
  • OpenSearch / OpenSearch-Dashboards core and components teams finalize their features

Campaigns

REPLACE with OpenSearch wide initiatives to improve quality and consistency.

### Code Complete - August 16th, 2022

Code Complete - August 19th, 2022

### Release testing - August 18th, 2022 - August 19th, 2022

Release testing - August 18th, 2022 - August 23rd, 2022

  • Declare a release candidate build, and provide the instructions with the release candidates for teams on testing (August 17th 2022).
  • Stop builds for this version of OpenSearch and/or OpenSearch Dashboards in order to avoid accidental commits going in unknowingly. Restart only if necessary else manually run the build workflow and declare new release candidate.
  • Sanity Testing: Sanity testing and fixing of critical issues found by teams. Teams test their components within the distribution, ensuring integration, backwards compatibility, and perf tests pass.
  • Publish all test results in the comments of this issue.

### Performance testing validation - August 17th, 2022

- [ ] Performance tests do not show a regression
- [ ] Longevity tests do not show any issues

### Release - August 23rd, 2022
### Release - August 25rd, 2022

Release - August 30th, 2022

Post Release

  • Create release tags for each component (Jenkins job name: release-tag-creation).
  • Replace refs in manifests/1.3.5 with tags and remove checks.
  • If this is a major or minor version release, stop building previous patch version.
  • Generate distribution release notes reviewed by PM team for opensearch-build repository.
  • Increment version for Helm Charts (sample PR) for the 1.3.5 release.
  • Increment version for Ansible Charts (sample PR) for the 1.3.5 release.
  • Prepare for next patch release by incrementing patch versions for each component.
  • Update this template with any new or missed steps.
  • Create an issue for a retrospective, solicit feedback, and publish a summary.

Components

Replace with links to all component tracking issues.

Component On track Release Notes
N/A N/A N/A
Legend

Symbol Meaning
🟢 On track with overall release
🟡 Missed last milestone
🔴 Missed multiple milestones

@github-actions github-actions bot added release untriaged Issues that have not yet been triaged v{{ env.VERSION }} labels Jul 19, 2022
@bbarani bbarani removed the untriaged Issues that have not yet been triaged label Jul 19, 2022
@gaiksaya gaiksaya pinned this issue Aug 16, 2022
@bbarani
Copy link
Member

bbarani commented Aug 29, 2022

Hello OpenSearch community. We have discovered a potential last minute issue and need to perform due diligence on it. The teams are still working on this and we will provide another update by the 31st. Your patience is appreciated. Please refer to https://forum.opensearch.org/t/update-1-3-5-2-2-1-on-hold/10727 for current status.

@prudhvigodithi
Copy link
Member

Release testing

08/30/2022
We have new Artifacts built and ready for testing.


OpenSearch docker

Start without security
Docker command docker pull opensearchstaging/opensearch:1.3.5.5996 && docker run -it -d -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:1.3.5.5996
Connect command curl http://localhost:9200
Start with security
Docker command docker pull opensearchstaging/opensearch:1.3.5.5996 && docker run -it -d -p 9200:9200 -e "discovery.type=single-node" opensearchstaging/opensearch:1.3.5.5996
Connect command curl --insecure https://admin:admin@localhost:9200

OpenSearch-Dashboards docker

Start without security
Docker command docker pull opensearchstaging/opensearch-dashboards:1.3.5.4074 && docker run -it -d --network="host" -e "DISABLE_SECURITY_DASHBOARDS_PLUGIN=true" opensearchstaging/opensearch-dashboards:1.3.5.4074
URL http://localhost:5601
Start without security
Docker command docker pull opensearchstaging/opensearch-dashboards:1.3.5.4074 && docker run -it -d --network="host" opensearchstaging/opensearch-dashboards:1.3.5.4074
URL http://localhost:5601

Use TARs to deploy OpenSearch Manually

OpenSearch - Build 5996

arm64 [manifest] [tar] [rpm] [yum]
x64 [manifest] [tar] [rpm] [yum]

OpenSearch Dashboards - Build 4074

arm64 [manifest] [tar][rpm] [yum]
x64 [manifest] [tar][rpm] [yum]

@bbarani
Copy link
Member

bbarani commented Aug 30, 2022

We have got a green signal to release 1.3.5 on Sept 01 2022 and we have started prepping for the release.

@opensearch-ci-bot
Copy link
Collaborator

OpenSearch CommitID(after 2022-07-14) & Release Notes info

Repo Branch CommitID Commit Date Release Notes
OpenSearch 1.3 6cabc6a 2022-08-15 False
common-utils 1.3 f30b07d 2022-08-16 False
job-scheduler 1.3 f3dba24 2022-08-22 False
alerting 1.3 f0a5eb4 2022-08-16 False
ml-commons 1.3 6230153 2022-08-16 False
security 1.3 c7bdcb5 2022-08-23 True
k-NN 1.3 c190660 2022-08-16 False
performance-analyzer 1.3 46468b1 2022-08-17 False
asynchronous-search 1.3 260e8f2 2022-08-19 False
anomaly-detection 1.3 7475ab8 2022-08-17 False
index-management 1.3 b47bcb1 2022-08-18 False
cross-cluster-replication 1.3 917f535 2022-08-26 True
dashboards-reports 1.3 f255abd 2022-08-17 False
opensearch-observability 1.3 05cd955 2022-08-17 False
sql 1.3 7e12bff 2022-08-17 False

@opensearch-ci-bot
Copy link
Collaborator

OpenSearch Dashboards CommitID(after 2022-07-14) & Release Notes info

Repo Branch CommitID Commit Date Release Notes
OpenSearch-Dashboards 1.3 6805701 2022-08-25 False
functionalTestDashboards 1.3 a0267e6 2022-08-18 False
securityDashboards 1.3 7d75048 2022-08-22 True
anomalyDetectionDashboards 1.3 f9e5753 2022-08-16 False
indexManagementDashboards 1.3 cacb9d6 2022-08-18 False
queryWorkbenchDashboards 1.3 7e12bff 2022-08-17 False
reportsDashboards 1.3 f255abd 2022-08-17 False
ganttChartDashboards 1.3 a26d50d 2022-08-16 False
observabilityDashboards 1.3 05cd955 2022-08-17 False
alertingDashboards 1.3 8c6c8e5 2022-08-17 False

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Aug 30, 2022

OpenSearch 5996 integ-test result.

Success with arm64

Failed with x64

2022-08-30 18:50:47 INFO     | index-management     | with-security        | PASS  |    0 |
2022-08-30 18:50:47 ERROR    | index-management     | without-security     | FAIL  |    1 |

@bowenlan-amzn can you please confirm again, if this comment is still valid for this failure.

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Aug 30, 2022

OpenSearch Dashboard 4074 integ-test result.

with-security

✖  1 of 42 failed

plugins/observability-dashboards/7_      08:06        8        5        3        -        - │
  │    app_analytics.spec.js                                                                       │

without-security

✖  2 of 42 failed 

plugins/alerting-dashboards-plugin/      01:32        4        3        1        -        - │
  │    bucket_level_monitor_spec.js           

plugins/observability-dashboards/7_      06:29        8        7        1        -        - │
  │    app_analytics.spec.js  

@Angie-Zhang
Copy link
Contributor

OpenSearch 5996 integ-test result

We have merged the PR for fixing. @prudhvigodithi Could you test it again?

@bowenlan-amzn
Copy link
Member

The failure this time is different, but still an observed flaky test recorded here. We will look into it later.

  2> REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.indexmanagement.transform.TransformRunnerIT.test no-op execution when no buckets have been modified" -Dtests.seed=5DCD6D7B8AAB3141 -Dtests.security.manager=false -Dtests.locale=es-MX -Dtests.timezone=Europe/Minsk -Druntime.java=11

  2> java.lang.NullPointerException

        at __randomizedtesting.SeedInfo.seed([5DCD6D7B8AAB3141:6E4476B0B23793F7]:0)

        at java.base/java.time.Instant.compareTo(Instant.java:1254)

        at org.opensearch.indexmanagement.transform.TransformRunnerIT$test no-op execution when no buckets have been modified$secondIterationMetadata$1.invoke(TransformRunnerIT.kt:428)

        at org.opensearch.indexmanagement.transform.TransformRunnerIT$test no-op execution when no buckets have been modified$secondIterationMetadata$1.invoke(TransformRunnerIT.kt:30)

        at org.opensearch.indexmanagement.TestHelpersKt.waitFor(TestHelpers.kt:119)

        at org.opensearch.indexmanagement.TestHelpersKt.waitFor$default(TestHelpers.kt:113)

        at org.opensearch.indexmanagement.transform.TransformRunnerIT.test no-op execution when no buckets have been modified(TransformRunnerIT.kt:424)

@prudhvigodithi
Copy link
Member

We have merged the PR for fixing. @prudhvigodithi Could you test it again?

Hey @Angie-Zhang thanks can you please share the PR here, just to track on this issue.

@prudhvigodithi
Copy link
Member

The failure this time is different, but still an observed flaky test recorded here. We will look into it later.

Thanks @bowenlan-amzn that being said we can ignore this for the release?

@Angie-Zhang
Copy link
Contributor

Angie-Zhang commented Aug 31, 2022

The failure this time is different, but still an observed flaky test recorded here. We will look into it later.

Thanks @bowenlan-amzn that being said we can ignore this for the release?

I checked the log, it was caused by random seed issue. We can ignore this for the release. We may fix it later then back port it.

@AWSHurneyt
Copy link
Contributor

OpenSearch Dashboard 4074 integ-test result.

with-security

✖  1 of 42 failed

plugins/observability-dashboards/7_      08:06        8        5        3        -        - │
  │    app_analytics.spec.js                                                                       │

without-security

✖  2 of 42 failed 

plugins/alerting-dashboards-plugin/      01:32        4        3        1        -        - │
  │    bucket_level_monitor_spec.js           

plugins/observability-dashboards/7_      06:29        8        7        1        -        - │
  │    app_analytics.spec.js  

Looking into the alerting dashboard bucket_level_monitor_spec test failure. There is 1 test in bucket_level_monitor_spec that can be flaky depending on how long it takes for the sample data index to be created. I suspect that's causing this failure after looking at the stacktrace with @prudhvigodithi yesterday. He mentioned today that the test failed with the same error again. Continuing to investigate. Haven't been able to replicate the error yet; all alerting dashboards tests pass locally.

@eugenesk24
Copy link
Contributor

Looking into app_analytics test failure

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Aug 31, 2022

OpenSearch CommitID(after 2022-07-14) & Release Notes info

Repo Branch CommitID Commit Date Release Notes
OpenSearch 1.3 ['1cf7ea2', '6cabc6a', '9b03eac', '08cdd07'] ['2022-08-31', '2022-08-15', '2022-08-05', '2022-08-04'] True
common-utils 1.3 ['f30b07d'] ['2022-08-16'] False
job-scheduler 1.3 ['f3dba24'] ['2022-08-22'] False
alerting 1.3 ['f0a5eb4'] ['2022-08-16'] False
ml-commons 1.3 ['6230153', '5c39b4a'] ['2022-08-16', '2022-07-28'] False
security 1.3 ['c7bdcb5', '87f43fd', '942a6df', '46fd8a2'] ['2022-08-23', '2022-08-15', '2022-08-15', '2022-08-12'] True
k-NN 1.3 [] [] False
performance-analyzer 1.3 ['46468b1', '75f2846', 'af2d905'] ['2022-08-17', '2022-08-16', '2022-08-15'] False
asynchronous-search 1.3 [] [] False
anomaly-detection 1.3 ['7475ab8'] ['2022-08-17'] False
index-management 1.3 ['b47bcb1', '02a0fcb', 'f8113ce'] ['2022-08-18', '2022-08-16', '2022-07-27'] False
cross-cluster-replication 1.3 ['917f535', 'ba8f6a4', '4b4df0a', 'b463bf8', '317a81c', 'f6c862b', 'b01f3c8'] ['2022-08-26', '2022-08-26', '2022-08-26', '2022-08-26', '2022-08-22', '2022-08-19', '2022-08-18'] True
dashboards-reports 1.3 ['f255abd', '9976c92', '7421b59', '64bb6b9', '7ea1d00'] ['2022-08-17', '2022-08-17', '2022-08-16', '2022-08-16', '2022-08-16'] False
opensearch-observability 1.3 ['05cd955', '7b402b9'] ['2022-08-17', '2022-08-16'] False
sql 1.3 ['7e12bff', '348cead'] ['2022-08-17', '2022-08-12'] False

OpenSearch Dashboards CommitID(after 2022-07-14) & Release Notes info

Repo Branch CommitID Commit Date Release Notes
OpenSearch-Dashboards 1.3 ['6805701', 'd81a165', 'b7ef826', '683a738'] ['2022-08-25', '2022-08-23', '2022-08-23', '2022-08-23'] False
functionalTestDashboards 1.3 [] [] False
securityDashboards 1.3 ['7d75048', 'baed4b0'] ['2022-08-22', '2022-08-17'] True
anomalyDetectionDashboards 1.3 [] [] False
indexManagementDashboards 1.3 [] [] False
queryWorkbenchDashboards 1.3 ['7e12bff', '348cead'] ['2022-08-17', '2022-08-12'] False
reportsDashboards 1.3 ['f255abd', '9976c92', '7421b59', '64bb6b9', '7ea1d00'] ['2022-08-17', '2022-08-17', '2022-08-16', '2022-08-16', '2022-08-16'] False
ganttChartDashboards 1.3 [] [] False
observabilityDashboards 1.3 ['05cd955', '7b402b9'] ['2022-08-17', '2022-08-16'] False
alertingDashboards 1.3 [] [] False

@prudhvigodithi
Copy link
Member

1.3.5 Native plugin validation to install repository-s3

6. sudo ./opensearch-plugin install repository-s3
-> Installing repository-s3
-> Downloading repository-s3 from opensearch
[=================================================] 100%   
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@     WARNING: plugin requires additional permissions     @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
* java.lang.RuntimePermission accessDeclaredMembers
* java.lang.RuntimePermission getClassLoader
* java.lang.reflect.ReflectPermission suppressAccessChecks
* java.net.NetPermission setDefaultAuthenticator
* java.net.SocketPermission * connect,resolve
* java.util.PropertyPermission opensearch.allow_insecure_settings read,write
See http://docs.oracle.com/javase/8/docs/technotes/guides/security/permissions.html
for descriptions of what these permissions allow and the associated risks.

Continue with installation? [y/N]y
1. -> Installed repository-s3 with folder name repository-s3

@prudhvigodithi
Copy link
Member

OpenSearch 1.3.5 release maven validation
Screen Shot 2022-09-01 at 11 36 43 AM

@prudhvigodithi
Copy link
Member

Release 1.3.5 https://opensearch.org/versions/opensearch-1-3-5.html
Closing this release issue.
@bbarani

@prudhvigodithi prudhvigodithi unpinned this issue Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment