Skip to content

Commit

Permalink
Bumps node version to 14.18.2 for Dashboards Node upgrade (#1350)
Browse files Browse the repository at this point in the history
Signed-off-by: Bishoy Boktor <[email protected]>
  • Loading branch information
boktorbb authored Jan 20, 2022
1 parent c3aa0e6 commit 824674d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions DEVELOPER_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ On Windows, run `pyenv rehash` if `pipenv` cannot be found. This rehashes pyenv

#### NVM and Node

Install [nvm](https://github.com/nvm-sh/nvm/blob/master/README.md) to use the Node 10.24.1 version as it is required
Install [nvm](https://github.com/nvm-sh/nvm/blob/master/README.md) to use the Node 14.18.2 version as it is required

```
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash
nvm install v10.24.1
nvm install v14.18.2
```

#### Yarn
Expand Down
2 changes: 1 addition & 1 deletion docker/ci/dockerfiles/ci-runner.al2.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ WORKDIR /usr/share/opensearch
# Hard code node version and yarn version for now
# nvm environment variables
ENV NVM_DIR /usr/share/opensearch/.nvm
ENV NODE_VERSION 10.24.1
ENV NODE_VERSION 14.18.2
# install nvm
# https://github.com/creationix/nvm#install-script
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash
Expand Down
2 changes: 1 addition & 1 deletion docker/ci/dockerfiles/ci-runner.centos7.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ WORKDIR /usr/share/opensearch
# Hard code node version and yarn version for now
# nvm environment variables
ENV NVM_DIR /usr/share/opensearch/.nvm
ENV NODE_VERSION 10.24.1
ENV NODE_VERSION 14.18.2
# install nvm
# https://github.com/creationix/nvm#install-script
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash
Expand Down

0 comments on commit 824674d

Please sign in to comment.