Add uninstall function for tar integTest between plugins (#2020)

* Add uninstall function for tar integTest between plugins Signed-off-by: Peter Zhu <[email protected]> * Fix isort Signed-off-by: Peter Zhu <[email protected]>
opensearch-project · Apr 21, 2022 · 464b769 · 464b769
1 parent 30aedfb
commit 464b769
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/src/test_workflow/integ_test/distribution.py b/src/test_workflow/integ_test/distribution.py
@@ -47,8 +47,9 @@ def start_cmd(self) -> str:
         """
         pass
 
+    @abstractmethod
     def uninstall(self) -> None:
         """
-        Allow distribution that is not 'tar' to do proper cleanup
+        Allow distribution to do proper cleanup
         """
         pass
diff --git a/src/test_workflow/integ_test/distribution_tar.py b/src/test_workflow/integ_test/distribution_tar.py
@@ -6,6 +6,7 @@
 
 import logging
 import os
+import subprocess
 import tarfile
 
 from test_workflow.integ_test.distribution import Distribution
@@ -35,3 +36,7 @@ def start_cmd(self) -> str:
             "opensearch-dashboards": "./opensearch-dashboards",
         }
         return start_cmd_map[self.filename]
+
+    def uninstall(self) -> None:
+        logging.info(f"Cleanup {self.work_dir}/* content after the test")
+        subprocess.check_call(f"rm -rf {self.work_dir}/*", shell=True)
diff --git a/tests/tests_test_workflow/test_integ_workflow/integ_test/test_distribution_tar.py b/tests/tests_test_workflow/test_integ_workflow/integ_test/test_distribution_tar.py
@@ -6,7 +6,7 @@
 
 import os
 import unittest
-from unittest.mock import MagicMock, patch
+from unittest.mock import MagicMock, Mock, patch
 
 from test_workflow.integ_test.distribution_tar import DistributionTar
 
@@ -43,3 +43,11 @@ def test_install(self) -> None:
     def test_start_cmd(self) -> None:
         self.assertEqual(self.distribution_tar.start_cmd, "./opensearch-tar-install.sh")
         self.assertEqual(self.distribution_tar_dashboards.start_cmd, "./opensearch-dashboards")
+
+    @patch("subprocess.check_call")
+    def test_uninstall(self, check_call_mock: Mock) -> None:
+        self.distribution_tar.uninstall()
+        args_list = check_call_mock.call_args_list
+
+        self.assertEqual(check_call_mock.call_count, 1)
+        self.assertEqual(f"rm -rf {self.work_dir}/*", args_list[0][0][0])