Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jenkins core version to 2.426.3 #435

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Divyaasm
Copy link
Collaborator

Description

Upgrade Jenkins core version

Issues Resolved

opensearch-project/opensearch-ci#389

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Divya Madala <[email protected]>
@Divyaasm Divyaasm changed the title Upgrade Jenkins score version to 2.426.3 Upgrade Jenkins core version to 2.426.3 Jun 11, 2024
@gaiksaya
Copy link
Member

Hi @Divyaasm Can you see if you can remove org.jenkins-ci.plugins dependencies? We added some of them to resolve the CVEs but since overall we are bumping the version, I don't think they are valid anymore.

@Divyaasm
Copy link
Collaborator Author

Hi @Divyaasm Can you see if you can remove org.jenkins-ci.plugins dependencies? We added some of them to resolve the CVEs but since overall we are bumping the version, I don't think they are valid anymore.

Sure, will take a look.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Divyaasm ,

All these deps are newly introduced simply because core upgrade?

Thanks.

@Divyaasm
Copy link
Collaborator Author

Hi @Divyaasm Can you see if you can remove org.jenkins-ci.plugins dependencies? We added some of them to resolve the CVEs but since overall we are bumping the version, I don't think they are valid anymore.

Hey @gaiksaya, tried by removing the dependencies, I've noticed that an older version than previously specified is being pulled. Shall we move forward with the current changes?

@gaiksaya
Copy link
Member

Hi @Divyaasm Can you see if you can remove org.jenkins-ci.plugins dependencies? We added some of them to resolve the CVEs but since overall we are bumping the version, I don't think they are valid anymore.

Hey @gaiksaya, tried by removing the dependencies, I've noticed that an older version than previously specified is being pulled. Shall we move forward with the current changes?

Sure! Thanks!

@Divyaasm Divyaasm merged commit cfba629 into opensearch-project:main Jun 11, 2024
6 of 7 checks passed
@prudhvigodithi
Copy link
Member

@Divyaasm @gaiksaya Should this change be backported ?

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 13, 2024
Signed-off-by: Divya Madala <[email protected]>
(cherry picked from commit cfba629)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gaiksaya
Copy link
Member

@Divyaasm @gaiksaya Should this change be backported ?

Yes! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants