Change min/max to overall_min/overall_max + update comparison results publisher #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… publisher Signed-off-by: Michael Oviedo <[email protected]>
Signed-off-by: Michael Oviedo <[email protected]>
OVI3D0
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
IanHoang
reviewed
Nov 15, 2024
| @@ -193,24 +193,27 @@ def build_aggregated_results(self): | |||
|
|
|||
| def calculate_weighted_average(self, task_metrics: Dict[str, List[Any]], iterations: int) -> Dict[str, Any]: | |||
| weighted_metrics = {} | |||
| num_executions = len(next(iter(task_metrics.values()))) | |||
| total_iterations = iterations * num_executions | |||
There was a problem hiding this comment.
To clarify, iterations is the number of iterations that the user inputted in workload params / default number of times a task is run in a workload? Not the number of times we executed the same test?
IanHoang
reviewed
Nov 15, 2024
osbenchmark/aggregator.py
Outdated
|
|
||
| for metric, values in task_metrics.items(): | ||
| if isinstance(values[0], dict): | ||
| weighted_metrics[metric] = {} | ||
| for item_key in values[0].keys(): | ||
| if item_key == 'unit': | ||
| weighted_metrics[metric][item_key] = values[0][item_key] | ||
| elif item_key == 'min': |
There was a problem hiding this comment.
Nit: We can improve the readability of this section by renaming item_key to something like metric_field
IanHoang
reviewed
Nov 15, 2024
osbenchmark/aggregator.py
Outdated
| else: | ||
| # for items like median or percentile values |
There was a problem hiding this comment.
For fields like median or containing percentile values
IanHoang
approved these changes
Nov 15, 2024
Signed-off-by: Michael Oviedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates min/max values in aggregated test results, to reflect the overall min/max values across all test executions, rather than just the average of each. The names of these values have also been prefixed with
overall_in order to reflect these changes. Changes were also made to theComparisonResultsPublisherclass, so these values can still be read if used in acomparecommand. Tests were also updated to reflect the recent changes to the aggregator class, and also to test theComparisonResultsPublisherclass.Issues Resolved
#684
Testing
make testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.