-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parameterize index.translog.durability in big5 workload #533
Merged
OVI3D0
merged 1 commit into
opensearch-project:main
from
OVI3D0:parameterize-index-translog-durability
Jan 8, 2025
Merged
parameterize index.translog.durability in big5 workload #533
OVI3D0
merged 1 commit into
opensearch-project:main
from
OVI3D0:parameterize-index-translog-durability
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Oviedo <[email protected]>
OVI3D0
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
December 16, 2024 20:30
IanHoang
approved these changes
Jan 7, 2025
IanHoang
added
backport 2
Backport to the "2" branch
backport 1
backport 3
Backport to the "3" branch
backport 7
Backport to the "7" branch
labels
Jan 7, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Michael Oviedo <[email protected]> (cherry picked from commit de3bc25) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Michael Oviedo <[email protected]> (cherry picked from commit de3bc25) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Michael Oviedo <[email protected]> (cherry picked from commit de3bc25) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jan 8, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Michael Oviedo <[email protected]> (cherry picked from commit de3bc25) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OVI3D0
pushed a commit
that referenced
this pull request
Jan 8, 2025
(cherry picked from commit de3bc25) Signed-off-by: Michael Oviedo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OVI3D0
pushed a commit
that referenced
this pull request
Jan 8, 2025
(cherry picked from commit de3bc25) Signed-off-by: Michael Oviedo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OVI3D0
pushed a commit
that referenced
this pull request
Jan 8, 2025
(cherry picked from commit de3bc25) Signed-off-by: Michael Oviedo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OVI3D0
pushed a commit
that referenced
this pull request
Jan 8, 2025
(cherry picked from commit de3bc25) Signed-off-by: Michael Oviedo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1
backport 2
Backport to the "2" branch
backport 3
Backport to the "3" branch
backport 7
Backport to the "7" branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parameterizes index.translog.durability in the big5 workload. Default is still async as the workload is intended to evaluate performance, and is not in itself a production use-case. The user can override this by passing in
--workload-params=index_translog_durability:"request"
for example.Issues Resolved
#515
Testing
New functionality includes testing
Tested by running big5 with/without new parameter
Backport to Branches:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.