Add vectorsearch README update regarding recall accuracy #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Hoang <[email protected]>
IanHoang
requested review from
gkamat,
beaioun,
cgchinmay,
rishabh6788,
VijayanB and
OVI3D0
as code owners
gkamat
approved these changes
Dec 6, 2024
| @@ -36,6 +36,9 @@ opensearch-benchmark execute-test \ | |||
| --pipeline benchmark-only \ | |||
| --kill-running-processes | |||
| ``` | |||
| ### Best Recall Results | |||
|
|
|||
| For accurate recall results, we recommend users to keep `search_clients` equal to or less than the number of CPU cores on the load generation host that is running the benchmark. | |||
There was a problem hiding this comment.
The command nproc can be used on Linux or MacOS to determine the number of cores.
IanHoang
added
backport 2
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Ian Hoang <[email protected]> (cherry picked from commit bb212c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Ian Hoang <[email protected]> (cherry picked from commit bb212c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Dec 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Ian Hoang <[email protected]> (cherry picked from commit bb212c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit bb212c1) Signed-off-by: Ian Hoang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit bb212c1) Signed-off-by: Ian Hoang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit bb212c1) Signed-off-by: Ian Hoang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
to joshpalis/opensearch-benchmark-workloads
that referenced
this pull request
Dec 18, 2024
…project#516) Signed-off-by: Ian Hoang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, users are mislead by the
recallvalue when using moresearch_clientsthan the number of CPU cores on the load generation host running the benchmark. We have already incorporated a short term fix for this opensearch-project/opensearch-benchmark#626 but would like to update the README too.Issues Resolved
#347
Backport to Branches:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.